Skip to content

AutoPr-KeyVault-KarishmaGhiya-REST Spec PrNumber 5563#5725

Merged
dsgouda merged 1 commit intoAzure:masterfrom
adxsdknet:RS-5563-KeyVault
Apr 10, 2019
Merged

AutoPr-KeyVault-KarishmaGhiya-REST Spec PrNumber 5563#5725
dsgouda merged 1 commit intoAzure:masterfrom
adxsdknet:RS-5563-KeyVault

Conversation

@adxsdknet
Copy link
Contributor

No description provided.

REST Spec PR 'Azure/azure-rest-api-specs#5563'
REST Spec PR Author 'KarishmaGhiya'
REST Spec PR Last commit
@weshaggard
Copy link
Member

@shahabhijeet Any idea whether or not this Auto-PR should have been generated? It is based off a change to a config for js in the sepc repo at Azure/azure-rest-api-specs#5563. Perhaps this triggered because of another earlier PR that didn't get merged based on a spec update but I wanted to be sure this is expected or if we should close it since it isn't related?

@dsgouda
Copy link
Contributor

dsgouda commented Apr 8, 2019

@weshaggard The last commit to the directory was on Feb 13 here, a day before we enabled auto generation of Net Sdk PRs

@weshaggard
Copy link
Member

@dsgouda so should we let this PR merge or is there some other process to getting things in-sync?

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Apr 8, 2019

@weshaggard Feel free to merge once Rest spec PR is merged.

@dsgouda dsgouda merged commit 2e226b8 into Azure:master Apr 10, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
REST Spec PR 'Azure/azure-rest-api-specs#5563'
REST Spec PR Author 'KarishmaGhiya'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants