Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs eng/common with updates from azure-sdk-tools PR 14400 by enhancing the link verification script to allow configurable exceptions for relative-link guidance.
Changes:
- Added a configurable allow-list file for page paths where relative links are permitted while still validating link correctness.
- Updated
Verify-Links.ps1to honor allow-listed pages instead of hardcodinginstructions.md. - Wired the new configuration into the pipeline verify-links step.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/allow-relative-links.txt | Introduces glob patterns that permit relative links for matching pages. |
| eng/common/scripts/Verify-Links.ps1 | Loads allow-list patterns and relaxes relative-link guidance per-page based on matches. |
| eng/common/pipelines/templates/steps/verify-links.yml | Passes the allow-list file path into the link verification script. |
weshaggard
approved these changes
Mar 10, 2026
…sFile parameter Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…idance checks active Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…-links.txt Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
…ll repos Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…, remove eng/** Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
Co-authored-by: weshaggard <9010698+weshaggard@users.noreply.github.com>
8ff68a4 to
fa31236
Compare
weshaggard
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14400 See eng/common workflow