[AutoPR Azure.ResourceManager.Discovery]-generated-from-SDK Generation - .NET-5975280#56854
[AutoPR Azure.ResourceManager.Discovery]-generated-from-SDK Generation - .NET-5975280#56854azure-sdk wants to merge 13 commits intoAzure:mainfrom
Conversation
…ig.yaml', API Version: 2026-02-01-preview, SDK Release Type: beta, and CommitSHA: '74cc90c49189a079b3cc93fde9c9ad76742f0184' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5975280 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…y from discovery SDK development
…rageAsset - Updated all test files with proper resource creation properties matching Python/Java SDKs - Added session recordings for Create, Get, List, Delete operations (sync + async) - Added [Ignore] for tests without recordings (CreateBookshelf, CreateWorkspace, CreateSupercomputer) - Trimmed LRO polling entries in create recordings to prevent playback timeout - All 165 tests pass in playback mode (71 passed, 94 skipped, 0 failures)
There was a problem hiding this comment.
Pull request overview
Adds the initial scaffolding for the Azure.ResourceManager.Discovery management SDK package generated from the 2026-02-01-preview spec.
Changes:
- Introduces new
Azure.ResourceManager.Discoveryproject/solution files and package metadata. - Adds initial README and CHANGELOG for the new package.
- Updates repo-wide CODEOWNERS and cspell configuration to include the new Discovery SDK area.
Reviewed changes
Copilot reviewed 7 out of 315 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/discovery/Azure.ResourceManager.Discovery/src/Azure.ResourceManager.Discovery.csproj | Adds the new SDK-style project file for the Discovery management library. |
| sdk/discovery/Azure.ResourceManager.Discovery/metadata.json | Declares tracked API version for the Discovery RP. |
| sdk/discovery/Azure.ResourceManager.Discovery/README.md | Adds initial package README content for onboarding and links. |
| sdk/discovery/Azure.ResourceManager.Discovery/CHANGELOG.md | Adds initial release notes for 1.0.0-beta.1. |
| sdk/discovery/Azure.ResourceManager.Discovery/Azure.ResourceManager.Discovery.sln | Adds solution file for local development. |
| .vscode/cspell.json | Adds Discovery-specific spelling allowlist entries for C# files. |
| .github/CODEOWNERS | Adds owners/labels for the new /sdk/discovery/ area. |
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <Description>This is the Azure.ResourceManager.Discovery client library for developing .NET applications with rich experience.</Description> | ||
| <AssemblyTitle>SDK Code Generation Azure.ResourceManager.Discovery</AssemblyTitle> | ||
| <Version>1.0.0-beta.1</Version> | ||
| <PackageTags>Azure.ResourceManager.Discovery</PackageTags> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| </PropertyGroup> | ||
| </Project> |
There was a problem hiding this comment.
This project file does not specify TargetFramework/TargetFrameworks. For SDK-style projects, MSBuild requires a target framework to be set (either in this csproj or via an imported props/targets); otherwise the project will fail to load/build. Add an explicit TargetFrameworks consistent with other Azure.ResourceManager packages in this repo (and keep other package/build properties aligned with the standard mgmt SDK project template).
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.0.31903.59 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Azure.ResourceManager.Discovery", "src\Azure.ResourceManager.Discovery.csproj", "{28FF4005-4467-4E36-92E7-DEA27DEB1519}" |
There was a problem hiding this comment.
The solution defines a single project ({28FF4005-...}) but ProjectConfigurationPlatforms contains configuration entries for multiple other project GUIDs that are not declared anywhere in the .sln. This makes the solution internally inconsistent and can lead to confusing VS behavior/noise. Remove the extraneous GUID configuration rows (keep only {28FF4005-...}) or regenerate the solution so the project list and configuration section match.
| {85677AD3-C214-42FA-AE6E-49B956CAC8DC}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {85677AD3-C214-42FA-AE6E-49B956CAC8DC}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Release|Any CPU.Build.0 = Release|Any CPU |
There was a problem hiding this comment.
The solution defines a single project ({28FF4005-...}) but ProjectConfigurationPlatforms contains configuration entries for multiple other project GUIDs that are not declared anywhere in the .sln. This makes the solution internally inconsistent and can lead to confusing VS behavior/noise. Remove the extraneous GUID configuration rows (keep only {28FF4005-...}) or regenerate the solution so the project list and configuration section match.
| {85677AD3-C214-42FA-AE6E-49B956CAC8DC}.Release|Any CPU.ActiveCfg = Release|Any CPU | |
| {85677AD3-C214-42FA-AE6E-49B956CAC8DC}.Release|Any CPU.Build.0 = Release|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Debug|Any CPU.Build.0 = Debug|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Release|Any CPU.ActiveCfg = Release|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Release|Any CPU.Build.0 = Release|Any CPU | |
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | |
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Debug|Any CPU.Build.0 = Debug|Any CPU | |
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Release|Any CPU.ActiveCfg = Release|Any CPU | |
| {1F1CD1D4-9932-4B73-99D8-C252A67D4B46}.Release|Any CPU.Build.0 = Release|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Debug|Any CPU.Build.0 = Debug|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Release|Any CPU.ActiveCfg = Release|Any CPU | |
| {28FF4005-4467-4E36-92E7-DEA27DEB1519}.Release|Any CPU.Build.0 = Release|Any CPU |
| # Visual Studio Version 17 | ||
| VisualStudioVersion = 17.0.31903.59 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Azure.ResourceManager.Discovery", "src\Azure.ResourceManager.Discovery.csproj", "{28FF4005-4467-4E36-92E7-DEA27DEB1519}" |
There was a problem hiding this comment.
The project type GUID {FAE04EC0-...} is the legacy C# project type. For SDK-style .NET projects, solutions typically use {9A19103F-16F7-4668-BE54-9A1E7A4F7556}. Updating the project type GUID helps Visual Studio treat the project correctly and aligns with the standard SDK-style solution format used across .NET repos.
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Azure.ResourceManager.Discovery", "src\Azure.ResourceManager.Discovery.csproj", "{28FF4005-4467-4E36-92E7-DEA27DEB1519}" | |
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Azure.ResourceManager.Discovery", "src\Azure.ResourceManager.Discovery.csproj", "{28FF4005-4467-4E36-92E7-DEA27DEB1519}" |
|
|
||
| This library follows the [new Azure SDK guidelines](https://azure.github.io/azure-sdk/general_introduction.html), and provides many core capabilities: | ||
|
|
||
| - Support MSAL.NET, Azure.Identity is out of box for supporting MSAL.NET. |
There was a problem hiding this comment.
Fix grammar in the README: line 9 is ungrammatical/repetitive, and line 27 should use 'a Microsoft Azure subscription' (not 'an'). These appear in the public-facing package README.
|
|
||
| ### Prerequisites | ||
|
|
||
| * You must have an [Microsoft Azure subscription](https://azure.microsoft.com/free/dotnet/). |
There was a problem hiding this comment.
Fix grammar in the README: line 9 is ungrammatical/repetitive, and line 27 should use 'a Microsoft Azure subscription' (not 'an'). These appear in the public-facing package README.
| "filename": "**/sdk/discovery/**/*.cs", | ||
| "words": [ | ||
| "adms", | ||
| "mobo" | ||
| ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
Adding very short, generic words like adms/mobo to the spellchecker allowlist can accidentally mask genuine typos across the Discovery SDK area. If these are required (e.g., specific acronyms), consider using the exact expected casing and/or narrowing the scope further (file-specific) to avoid reducing spellcheck signal.
| "filename": "**/sdk/discovery/**/*.cs", | |
| "words": [ | |
| "adms", | |
| "mobo" | |
| ] | |
| }, | |
| { |
- Record UpdateTool, UpdateStorageContainer, UpdateStorageAsset (sync + async) - Remove [Ignore] from Update tests (now have recordings) - Add [Timeout(9000000)] to DiscoveryManagementTestBase for 2-hour LROs - Trim LRO polling entries in Update recordings for playback - Re-add [Ignore] to CreateBookshelf (recording not yet captured)
…ig.yaml', API Version: 2026-02-01-preview, SDK Release Type: beta, and CommitSHA: '52f2a91499f8a39cfcb50453a9b36b8c3a681ed8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6001913 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Configurations: 'specification/discovery/Discovery.Management/tspconfig.yaml', API Version: 2026-02-01-preview, SDK Release Type: beta, and CommitSHA: '74cc90c49189a079b3cc93fde9c9ad76742f0184' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5975280 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=62b9c420-7ddb-f011-8544-000d3a3ac7ae Submitted by: alchocro@microsoft.com
Release Plan Details
Spec pull request: Discovery/2026 02 01 preview cp azure-rest-api-specs#39745
Spec API version: 2026-02-01-preview