Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14343#56772

Merged
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-AllowNpmJSAccess-14343
Mar 4, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14343#56772
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-AllowNpmJSAccess-14343

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14343 See eng/common workflow

Copilot AI review requested due to automatic review settings March 4, 2026 22:27
@azure-sdk azure-sdk requested a review from a team as a code owner March 4, 2026 22:27
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronizes eng/common pipeline templates with the upstream azure-sdk-tools changes from PR 14343, adjusting the npm publish job behavior when publishing to the public npm registry.

Changes:

  • Add a PowerShell step to delete a repo-level .npmrc when targeting https://registry.npmjs.org/ to ensure npm uses the default npmjs registry.
Comments suppressed due to low confidence (1)

eng/common/pipelines/templates/jobs/npm-publish.yml:85

  • This step runs even when SkipPublishing is set (e.g., when no packages are found and publishing is intentionally skipped). For consistency with the subsequent publish/verify steps and to avoid unnecessary workspace mutation/noise, add the same condition used elsewhere (and(succeeded(), ne(variables['SkipPublishing'], 'true'))).
          - task: PowerShell@2
            displayName: 'Delete repo .npmrc'
            inputs:
              targetType: inline
              script: |
                $npmrcPath = "$(System.DefaultWorkingDirectory)/.npmrc"
                if (Test-Path $npmrcPath) {
                  Remove-Item -Path $npmrcPath -Force
                  Write-Host "Deleted $npmrcPath to use default npmjs registry."
                } else {
                  Write-Host "No repo .npmrc found at $npmrcPath."
                }
              pwsh: true

@azure-sdk azure-sdk force-pushed the sync-eng/common-AllowNpmJSAccess-14343 branch from e0964af to 1b49878 Compare March 4, 2026 22:43
@chidozieononiwu chidozieononiwu merged commit 3b6e2e2 into main Mar 4, 2026
22 checks passed
@chidozieononiwu chidozieononiwu deleted the sync-eng/common-AllowNpmJSAccess-14343 branch March 4, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants