Sync eng/common directory with azure-sdk-tools for PR 14343#56772
Merged
chidozieononiwu merged 1 commit intomainfrom Mar 4, 2026
Merged
Sync eng/common directory with azure-sdk-tools for PR 14343#56772chidozieononiwu merged 1 commit intomainfrom
chidozieononiwu merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes eng/common pipeline templates with the upstream azure-sdk-tools changes from PR 14343, adjusting the npm publish job behavior when publishing to the public npm registry.
Changes:
- Add a PowerShell step to delete a repo-level
.npmrcwhen targetinghttps://registry.npmjs.org/to ensure npm uses the default npmjs registry.
Comments suppressed due to low confidence (1)
eng/common/pipelines/templates/jobs/npm-publish.yml:85
- This step runs even when
SkipPublishingis set (e.g., when no packages are found and publishing is intentionally skipped). For consistency with the subsequent publish/verify steps and to avoid unnecessary workspace mutation/noise, add the same condition used elsewhere (and(succeeded(), ne(variables['SkipPublishing'], 'true'))).
- task: PowerShell@2
displayName: 'Delete repo .npmrc'
inputs:
targetType: inline
script: |
$npmrcPath = "$(System.DefaultWorkingDirectory)/.npmrc"
if (Test-Path $npmrcPath) {
Remove-Item -Path $npmrcPath -Force
Write-Host "Deleted $npmrcPath to use default npmjs registry."
} else {
Write-Host "No repo .npmrc found at $npmrcPath."
}
pwsh: true
e0964af to
1b49878
Compare
chidozieononiwu
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14343 See eng/common workflow