Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14219#56611

Merged
azure-sdk merged 5 commits intomainfrom
sync-eng/common-AddGHAppWorkflowLogin-14219
Mar 2, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14219#56611
azure-sdk merged 5 commits intomainfrom
sync-eng/common-AddGHAppWorkflowLogin-14219

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14219 See eng/common workflow

Copilot AI review requested due to automatic review settings February 27, 2026 23:05
@azure-sdk azure-sdk requested a review from a team as a code owner February 27, 2026 23:05
@azure-sdk azure-sdk requested a review from weshaggard February 27, 2026 23:05
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Feb 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs eng/common with azure-sdk-tools PR 14219 by extending the existing GitHub App token minting script to work in GitHub Actions and adding a composite action wrapper for workflows.

Changes:

  • Updated eng/common/scripts/login-to-github.ps1 to document/support GitHub Actions and export tokens via GITHUB_ENV (with masking).
  • Added a new composite GitHub Action at eng/common/actions/login-to-github/action.yml that wraps the PowerShell script.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
eng/common/scripts/login-to-github.ps1 Adds GitHub Actions exporting/masking behavior and updates help/error output.
eng/common/actions/login-to-github/action.yml New composite action wrapper to call the script from GitHub Actions.

@azure-sdk azure-sdk merged commit 7288543 into main Mar 2, 2026
31 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-AddGHAppWorkflowLogin-14219 branch March 2, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants