Skip to content

DeploymentManager - SDK preview#5649

Merged
dsgouda merged 15 commits intoAzure:masterfrom
deveshguha:deoletim-adm-uts
Apr 8, 2019
Merged

DeploymentManager - SDK preview#5649
dsgouda merged 15 commits intoAzure:masterfrom
deveshguha:deoletim-adm-uts

Conversation

@deveshguha
Copy link
Copy Markdown
Member

Initial version of Deployment Manager SDK.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the code using generate.ps1 and commit changes.

@deveshguha
Copy link
Copy Markdown
Member Author

Incorporated feedback.

@deveshguha
Copy link
Copy Markdown
Member Author

Autogenerated using generate.ps1.
This required a change to readme.txt in rest-api-specs repo to have the right output directory. This change is in the PR Azure/azure-rest-api-specs#5489

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a couple of minor changes and should be good to go

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec is not merged. Approved in principle. @deveshguha Please regenerate the code once the spec is merged. Also, the .txt file generated is incorrect. Please make sure you delete and commit the one that is generated when you run the generate.ps1 script

@deveshguha
Copy link
Copy Markdown
Member Author

Spec is not merged. Approved in principle. @deveshguha Please regenerate the code once the spec is merged. Also, the .txt file generated is incorrect. Please make sure you delete and commit the one that is generated when you run the generate.ps1 script

Regenerated after the spec was merged.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

@deveshguha
Copy link
Copy Markdown
Member Author

LGTM will merge once CIs pass

Sounds good, thank you!

@dsgouda dsgouda merged commit 149dd1b into Azure:master Apr 8, 2019
@deveshguha deveshguha deleted the deoletim-adm-uts branch April 8, 2019 22:43
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
* Port from -pr repo

* UT framework; ArtifactSource CRUD tests

* Unit Tests

* Enhance unit tests

* Fix for Playback mode

* Update Tests to fetch SAS from storage

* Update TargetFramework

* Update tests, session records

* PR Feedback

* Autogenerate using generate.ps1

* PR Feedback

* Regerate sdk using generate.ps1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants