Skip to content

[AutoPR Azure.ResourceManager.ContainerServiceFleet]-generated-from-SDK Generation - .NET-5926806#56483

Closed
azure-sdk wants to merge 1 commit intoAzure:mainfrom
azure-sdk:sdkauto/Azure.ResourceManager.ContainerServiceFleet-5926806
Closed

[AutoPR Azure.ResourceManager.ContainerServiceFleet]-generated-from-SDK Generation - .NET-5926806#56483
azure-sdk wants to merge 1 commit intoAzure:mainfrom
azure-sdk:sdkauto/Azure.ResourceManager.ContainerServiceFleet-5926806

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented Feb 25, 2026

Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/fleet/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'd3e85dfd3b82ed7f275dc987656a65afda20a8f4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5926806 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=fd5c7709-d7cf-f011-bbd3-6045bd07ef68 Submitted by: ryan.zhang@microsoft.com

Release Plan Details

…osoft.ContainerService/fleet/tspconfig.yaml', API Version: 2025-08-01-preview, SDK Release Type: beta, and CommitSHA: 'd3e85dfd3b82ed7f275dc987656a65afda20a8f4' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5926806 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copy link
Copy Markdown
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this PR LGTM, but to release the SDK, we need to update the changelog.md file with a release date of the changes comparing with last released version, and a release date.

@ArcturusZhang
Copy link
Copy Markdown
Member

ArcturusZhang commented Feb 26, 2026

Also please resolve this issue in this PR: #56422
The code change to resolve this issue could be simple, just add a bool isAsync parameter on the public ctor and pass it to base, like this:

public FleetCRUD(bool isAsync): base(isAsync)

but it requires to record the test cases again.

@frantran
Copy link
Copy Markdown
Member

Also please resolve this issue in this PR: #56422 The code change to resolve this issue could be simple, just add a bool isAsync parameter on the public ctor and pass it to base, like this:

public FleetCRUD(bool isAsync): base(isAsync)

but it requires to record the test cases again.

@ArcturusZhang @ArthurMa1978 will the .NET SDK team work on resolving this issue?

@ArcturusZhang
Copy link
Copy Markdown
Member

Also please resolve this issue in this PR: #56422 The code change to resolve this issue could be simple, just add a bool isAsync parameter on the public ctor and pass it to base, like this:

public FleetCRUD(bool isAsync): base(isAsync)

but it requires to record the test cases again.

@ArcturusZhang @ArthurMa1978 will the .NET SDK team work on resolving this issue?

We are unable to record the test. We can fix the code, but some one from your side need to record it again.

@ArcturusZhang
Copy link
Copy Markdown
Member

Since this is a beta version, it is fine that we leave the issue here.
Please resolve the test issues in next stable version release.

@frantran
Copy link
Copy Markdown
Member

frantran commented Apr 7, 2026

replaced in favor of: #57844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants