PBI 3632670 2019 .Net SDK Release 1#5648
PBI 3632670 2019 .Net SDK Release 1#5648dsgouda merged 3 commits intoAzure:masterfrom BrianBlum:master
Conversation
We explicitly ran ~\src\SDKs\Media\Management.Media\generate.ps1 to get --opt-in-extensible-enums. The 'new' files in this PR are enum related files that were incorrectly deleted by #5490.
|
This was supposed to be submitted to psSDKJson6. Closing this PR. |
|
@BrianBlum reopening the PR. Our default branch has been switched to master now, |
|
@dsgouda, I didn't use the OpenAPI path to submit this code. Who should the reviewers be? |
I will review this one. Will revert soon. |
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks good for the most part.
Acknowledging that apparent breaking changes are actually enums being reverted to extensible enums
|
|
||
| [assembly: AssemblyVersion("2.0.1.0")] | ||
| [assembly: AssemblyFileVersion("2.0.1.0")] | ||
| [assembly: AssemblyVersion("2.0.2.0")] |
There was a problem hiding this comment.
AssemblyVersion remains the same, only AssemblyFileVersion must be bumped for non-major version bumps
There was a problem hiding this comment.
Thanks. Pushed new version of AssemblyInfo.cs.
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM will merge once CIs pass
|
Confirmed tests are fixed here |
* PBI 3632670 2019 .Net SDK Release 1 We explicitly ran ~\src\SDKs\Media\Management.Media\generate.ps1 to get --opt-in-extensible-enums. The 'new' files in this PR are enum related files that were incorrectly deleted by Azure#5490. * Update version of Media Services sdk. * AssemblyVersion should not have been incremented for this minor change.
2 participants
We explicitly ran ~\src\SDKs\Media\Management.Media\generate.ps1 to get --opt-in-extensible-enums.
The 'new' files in this PR are enum related files that were incorrectly deleted by #5490.