Skip to content

[AutoPR Azure.ResourceManager.ServiceFabricManagedClusters]-generated-from-SDK Generation - .NET-5919240#56433

Merged
iliu816 merged 10 commits intoAzure:mainfrom
azure-sdk:sdkauto/Azure.ResourceManager.ServiceFabricManagedClusters-5919240
Mar 12, 2026
Merged

[AutoPR Azure.ResourceManager.ServiceFabricManagedClusters]-generated-from-SDK Generation - .NET-5919240#56433
iliu816 merged 10 commits intoAzure:mainfrom
azure-sdk:sdkauto/Azure.ResourceManager.ServiceFabricManagedClusters-5919240

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented Feb 24, 2026

Configurations: 'specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2026-02-01, SDK Release Type: stable, and CommitSHA: '57a2504930224552a409d9435d523e631a6c93e2' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5919240 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2c8e6891-a411-f111-8406-000d3a5a7db7 Submitted by: iliu@microsoft.com

Release Plan Details

…manager/Microsoft.ServiceFabric/ServiceFabricManagedClusters/tspconfig.yaml', API Version: 2026-02-01, SDK Release Type: stable, and CommitSHA: '57a2504930224552a409d9435d523e631a6c93e2' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5919240 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@iliu816
Copy link
Copy Markdown
Member

iliu816 commented Feb 24, 2026

The NodeTypeFaultSimulation namespace is intended to be missing. It was added a part of a preview API/SDK and is not intended to be included in this GA release.

@iliu816 iliu816 marked this pull request as ready for review February 24, 2026 19:51
Copilot AI review requested due to automatic review settings February 24, 2026 19:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This is an automated pull request that updates the Azure.ResourceManager.ServiceFabricManagedClusters SDK from a preview version (2025-10-01-preview) to a stable release (2026-02-01). The changes include API version updates, removal of preview fault simulation features, and addition of two new properties for enhanced cluster and node type configuration.

Changes:

  • Updated API version from 2025-10-01-preview to 2026-02-01 across all generated code
  • Removed fault simulation preview features (methods, models, and related infrastructure)
  • Added EnableResilientEphemeralOsDisk property to ServiceFabricManagedNodeTypeData
  • Added SkipManagedNsgAssignment property to ServiceFabricManagedClusterData
  • Updated package version from 1.3.0-beta.6 to 1.3.0 (stable release)

Reviewed changes

Copilot reviewed 3 out of 55 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Updated spec commit hash and formatting
metadata.json Updated API version to 2026-02-01
*.csproj Version bump from beta to stable (1.3.0)
ServiceFabricManagedNodeTypeData.cs Added EnableResilientEphemeralOsDisk property
ServiceFabricManagedClusterData.cs Added SkipManagedNsgAssignment property
ServiceFabricManagedNodeTypeResource.cs Removed fault simulation methods, updated API version references
ServiceFabricManagedClusterResource.cs Removed fault simulation methods, updated API version references
*Collection.cs files Updated API version references in documentation and initialization
*RestOperations.cs files Removed fault simulation request builders
Models/* (fault simulation) Removed all fault simulation related model files
CollectionResults/* Removed fault simulation collection result classes
LongRunningOperation/* Removed FaultSimulationOperationSource
Extensions/Mockable*.cs Updated API version references
ArmServiceFabricManagedClustersModelFactory.cs Added new properties to factory methods, removed fault simulation factories

@live1206
Copy link
Copy Markdown
Member

live1206 commented Mar 3, 2026

🔍 CI Failure Analysis for PR #56433

Summary

Check Status Details
net - pullrequest ❌ Failed Build #5947616
Build Analyze PRBatch ❌ Failed Compilation error (CS0246)
Build Build PRBatch ❌ Failed Compilation error (CS0246)
Build Test * (11 jobs) ❌ Failed Cascading from build failure
Build Compliance ⏭️ Cancelled Depends on build
Build generate_*_matrix ✅ Success
🔒 SDLSources * ✅ Success
license/cla ✅ Success
checkenforcer ⏳ Pending Waiting for above checks

Root Cause: Build Failure — Missing Type Reference in Customization File

Error:

error CS0246: The type or namespace name 'NodeTypeFaultSimulation' could not be found
(are you missing a using directive or an assembly reference?)

File: src/Customization/Models/FaultSimulationDetails.cs (line 14)

The generated code removed the NodeTypeFaultSimulation type (it was preview-only, not present in the GA API version 2026-02-01), but the hand-written customization file still references it:

public partial class FaultSimulationDetails
{
    public IReadOnlyList<NodeTypeFaultSimulation> NodeTypeFaultSimulation { get; }
}

This single compilation error cascades to all 14 failing checks (Build, Pack, and all Test jobs).

How to Fix

Step 1: Remove or update the customization file that references the removed preview type:

# If NodeTypeFaultSimulation is not needed for GA, remove the customization:
git rm sdk/servicefabricmanagedclusters/Azure.ResourceManager.ServiceFabricManagedClusters/src/Customization/Models/FaultSimulationDetails.cs

If the NodeTypeFaultSimulation type is still needed in the GA surface, it should be added back in the TypeSpec definition for the 2026-02-01 API version.

Additional Issues (will surface after build is fixed)

  1. CHANGELOG not updated: Currently shows ## 1.3.0-beta.6 (Unreleased) but package version is 1.3.0. Update to:

    ## 1.3.0 (Unreleased)
    
    ### Features Added
    - Upgraded to API version 2026-02-01 (stable).
    - Added `SkipManagedNsgAssignment` property to `ServiceFabricManagedClusterData`.
    
    ### Breaking Changes
    - Removed preview-only fault simulation types (`NodeTypeFaultSimulation`, `FaultSimulationStatus`, `SfmcOperationStatus`).
  2. API listing files: After fixing the build, regenerate public API listings:

    eng/scripts/Export-API.ps1 servicefabricmanagedclusters

@iliu816 iliu816 enabled auto-merge (squash) March 3, 2026 17:15
@iliu816
Copy link
Copy Markdown
Member

iliu816 commented Mar 9, 2026

@ArcturusZhang @ArthurMa1978 Hi, may I get a review for this PR please?

@iliu816 iliu816 merged commit e6c5df9 into Azure:main Mar 12, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants