Skip to content

.NET SDK Resource Provider:'StorageSync': version bump and test fixes#5625

Merged
dsgouda merged 8 commits intoAzure:masterfrom
anpint:storagesync-2019-02-01
Mar 29, 2019
Merged

.NET SDK Resource Provider:'StorageSync': version bump and test fixes#5625
dsgouda merged 8 commits intoAzure:masterfrom
anpint:storagesync-2019-02-01

Conversation

@anpint
Copy link
Member

@anpint anpint commented Mar 29, 2019

This is a follow-up to this PR which was auto-generated and merged: #5596

Swagger PR for 2019-02-01 API version: Azure/azure-rest-api-specs#5210

Contains the following changes for the StorageSync SDK:

  • Update version in Microsoft.Azure.Management.StorageSync.csproj from 2.8.0-preview to 2.9.0
  • Update release notes in Microsoft.Azure.Management.StorageSync.csproj
  • Fix tests, and update recordings for the new API version (2019-02-01)
  • Update changelog.md

@ankushbindlish2
Copy link
Member

ankushbindlish2 commented Mar 29, 2019

<PackageId>Microsoft.Azure.Management.StorageSync</PackageId>
<Description>Provides management capabilities for Azure Storage Sync.</Description>
<Version>2.8.0-preview</Version>
<Version>2.9.0</Version>
Copy link
Member

@ankushbindlish2 ankushbindlish2 Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.9.0 [](start = 8, length = 24)

@dsgouda @shahabhijeet , Please help confirm the version. we are trying to provide a stable version number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable version here should be 3.0.0
Please update the AssemblyInfo.cs file too

Copy link
Member

@ankushbindlish2 ankushbindlish2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

<PackageId>Microsoft.Azure.Management.StorageSync</PackageId>
<Description>Provides management capabilities for Azure Storage Sync.</Description>
<Version>2.8.0-preview</Version>
<Version>2.9.0</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable version here should be 3.0.0
Please update the AssemblyInfo.cs file too

@anpint
Copy link
Member Author

anpint commented Mar 29, 2019

@dsgouda I updated the version number in the project file, but I couldn't find a corresponding AssemblyInfo.cs to update.

@ankushbindlish2
Copy link
Member

@anpint
Copy link
Member Author

anpint commented Mar 29, 2019

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 4d81627 into Azure:master Mar 29, 2019
@anpint anpint deleted the storagesync-2019-02-01 branch April 19, 2019 23:59
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
…Azure#5625)

* generate new SDK version for 2019-02-01

* uncomment delete not exists test for SEP

* undo a change

* update test recordings

* update local path for SEP test

* Update version to 3.0.0

* Create AssemblyInfo.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants