Skip to content

[Cogs Face] Generate latest Face SDK from Swagger, including the Multiple Recognition Model features of Face API.#5589

Merged
dsgouda merged 5 commits intoAzure:masterfrom
acured:AddMultipleModelSDK
Mar 27, 2019
Merged

[Cogs Face] Generate latest Face SDK from Swagger, including the Multiple Recognition Model features of Face API.#5589
dsgouda merged 5 commits intoAzure:masterfrom
acured:AddMultipleModelSDK

Conversation

@lebronJ
Copy link
Contributor

@lebronJ lebronJ commented Mar 26, 2019

Regenerate Face SDK based on latest spec Azure/azure-rest-api-specs#5381 with latest published version to enable Multiple Recognition Model features.

  • Modify unit test cases with new API parameters, re-record unit-test session records and ensure all tests can pass.
  • Increment package version to 3.0.0-preview, because we have added new parameters in request url.
    (Have passed review and gotten exception for this from Azure API Review Board)
    (Let me know for any concerns)
  • Updated release notes.

@dsgouda
Copy link
Contributor

dsgouda commented Mar 26, 2019

@lebronJ please link the rest spec pr

@lebronJ
Copy link
Contributor Author

lebronJ commented Mar 26, 2019

@lebronJ please link the rest spec pr

I think I have already linked rest spec pr: Azure/azure-rest-api-specs#5381 in the PR description?

@acured acured force-pushed the AddMultipleModelSDK branch from 49b0aa0 to 2f490c1 Compare March 27, 2019 04:56
@lebronJ
Copy link
Contributor Author

lebronJ commented Mar 27, 2019

@dsgouda , we have merged the auto generated PR to this, so that this PR only contains versioning bump, release notes and test changes with new records. Please help review. I suppose after this is merged, we can move forward to publish the upgraded NuGet package.

@dsgouda
Copy link
Contributor

dsgouda commented Mar 27, 2019

@lebronJ that is correct.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing here

@dsgouda dsgouda merged commit c93855f into Azure:master Mar 27, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
…iple Recognition Model features of Face API. (Azure#5589)

* Auto generate faceSDK, aligned with latest Face API.

* Update test and session records.

* Update PackageReleaseNotes.

* Revert "Auto generate faceSDK, aligned with latest Face API."

This reverts commit ce41bcf2d4415f014dbc0ffca48372b9e7cb971d.

* Update version to 2.4.0-preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments