Bring NetApp Files to R3.5 standard#5565
Conversation
…or-net into NFSAAS-1504-NetApp_SDK
With review corrections.
Updating header
NFSAAS-2235 bring dotnet to R3.5 standard
|
@dsgouda you have added the changes requested label but I don't see any actions stated. Is there something I'm required to do? Thanks. |
|
@leonardbf Please pull down latest changes from master and resolve the conflicts or recreate the changes branch and open a new PR |
… into NFSAAS-2235-NET-SDK-R35
Nfsaas 2235 net sdk r35
|
@dsgouda I have pulled from upstream into my branch. |
|
@leonardbf I missed that you were targeting the psSdkJson6 branch, we have switched our default branch from psSdkJson6 to master. Please update the branch again with master, I shall post my review in the meantime. |
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(SdkTargetFx)</TargetFrameworks> | ||
| <TargetFrameworks>net452;netstandard1.4</TargetFrameworks> |
There was a problem hiding this comment.
No. I shall change it back.
| <Version>0.9.0-preview</Version> | ||
| <Version>0.9.1-preview</Version> | ||
| <PackageTags>MicrosoftAzure Management;NetApp</PackageTags> | ||
| <PackageReleaseNotes> |
There was a problem hiding this comment.
Please update the PackageReleaseNotes
| <PackageId>NetApp.Tests</PackageId> | ||
| <Description>NetApp.Tests Class Library</Description> | ||
| <AssemblyName>NetApp.Tests</AssemblyName> | ||
| <Version>1.0.0-preview</Version> |
There was a problem hiding this comment.
Test projects are never published. Please set this to 1.0.0 and do not modify henceforth
3 participants
Includes export policy and active directory.
Still in preview - breaking changes are not an issue
Swagger:
https://github.com/leonardbf/azure-rest-api-specs/tree/master/specification/netapp/resource-manager
Last swagger PR:
Azure/azure-rest-api-specs#5446