Skip to content

[AzureMonitorExporter] [AzureMonitorDistro] Sample Rate bug #55387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xiang17 wants to merge 1 commit into from
Closed

[AzureMonitorExporter] [AzureMonitorDistro] Sample Rate bug #55387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions ...penTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/SampleRateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,20 +74,32 @@ public void ValidateSampleRateInTelemetry(float sampleRate)
[Fact]
public void SampleRateE2ETest()
{
Environment.SetEnvironmentVariable("OTEL_TRACES_SAMPLER", "microsoft.fixed_percentage");
Environment.SetEnvironmentVariable("OTEL_TRACES_SAMPLER_ARG", "0.1");
using var activitySource = new ActivitySource(ActivitySourceName);
using var tracerProvider = Sdk.CreateTracerProviderBuilder()
.AddSource(ActivitySourceName)
.AddAzureMonitorTraceExporterForTest(out List<TelemetryItem> telemetryItems, options => options.SamplingRatio = 1.0F)
.AddAzureMonitorTraceExporterForTest(out List<TelemetryItem> telemetryItems)
.Build();

using (var activity = activitySource.StartActivity("SayHello"))
for (var i = 0; i < 10; i++)
{
using (var activity = activitySource.StartActivity("SayHello"))
{
}
}

tracerProvider?.ForceFlush();

Assert.NotEmpty(telemetryItems);
Assert.Null(telemetryItems.Last()!.SampleRate);
// Filter to only dependency telemetry items.
var dependencyTelemetryItems = telemetryItems.Where(t => t.Name == "RemoteDependency").ToList();

Assert.NotEmpty(dependencyTelemetryItems);

// With 10 spans and 10% sampling, we should have about 2 RemoteDependency telemetry items.
// Actual count may vary due to randomness of sampling, but definitely below a certain threshold, for example, 5.
Assert.True(dependencyTelemetryItems.Count < 5);
Assert.Null(dependencyTelemetryItems.Last()!.SampleRate);
}

[Fact]
Expand Down
Loading