Skip to content

Conversation

@ArthurMa1978
Copy link
Member

Fixes #54710
Spec PR: Azure/azure-rest-api-specs#40032

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copilot AI review requested due to automatic review settings January 29, 2026 16:29
@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Jan 29, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the Azure.ResourceManager.AppComplianceAutomation SDK to support the new Management Plane Generator (MPG). The migration involves regenerating code using TypeSpec-based tooling, updating generated patterns to align with the new generator, and adding backward compatibility customizations for existing public APIs.

Changes:

  • Adds tsp-location.yaml configuration file for TypeSpec-based code generation
  • Updates generated code patterns including serialization, constructors, and internal utilities
  • Removes null parameter from GetAllAsync() call in tests to match new API signature
  • Adds custom collection classes to maintain backward compatibility with existing method signatures
  • Updates project configuration and asset references

Reviewed changes

Copilot reviewed 12 out of 245 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml New TypeSpec configuration file defining spec location and generation settings
SnapshotTests.cs Updated test to remove null parameter from GetAllAsync() call
Sample_*.cs (13 files) Removed auto-generated comments from sample files
Generated/Models/*.cs (100+ files) Updated model classes with new serialization patterns and field naming
Generated/Internal/*.cs (20+ files) Added new internal utility classes for serialization and pagination
Generated/LongRunningOperation/*.cs (6 files) Updated operation source classes with new patterns
Generated/CollectionResults/*.cs (2 files) Added new collection result classes for pagination
Generated/*Resource.Serialization.cs (5 files) Updated resource serialization implementation
Generated/*Data.cs (2 files) Updated data class constructors and field ordering
Custom/*.cs (8 files) Added backward compatibility customizations for collection methods
Azure.ResourceManager.AppComplianceAutomation.csproj Removed obsolete IncludeAutorestDependency property
metadata.json Added API version metadata
assets.json Updated asset tag reference

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.AppComplianceAutomation

@live1206 live1206 merged commit 6ca2630 into main Jan 30, 2026
22 checks passed
@live1206 live1206 deleted the mgmt-appcompliance branch January 30, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MPG migration - appcomplianceautomation

2 participants