[AutoPR Azure.ResourceManager.containerregistrytasks]-generated-from-SDK Generation - .NET-5780622#55160
Merged
live1206 merged 18 commits intoAzure:mainfrom Mar 13, 2026
Conversation
…rosoft.ContainerRegistry/RegistryTasks/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '3f223d61b02c0496581dfb71c78104761b448d5e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5780622 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Contributor
|
Reviewed with @lizMSFT. As far as I'm aware, past SDK releases for container registry have been multi-api. Could you help us understand if any updates are needed to continue supporting multi-API until the consolidation work is finished? |
CodeJourneys
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the initial, auto-generated scaffolding for the new Azure.ResourceManager.containerregistrytasks management SDK (API version 2025-03-01-preview) to support the upcoming beta release.
Changes:
- Introduces the core project, solution, and build props for the new management library.
- Adds package metadata files (assets.json, changelog) and a starter README.
- Adds a samples project referencing the new library.
Reviewed changes
Copilot reviewed 7 out of 195 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/src/Azure.ResourceManager.containerregistrytasks.csproj | Adds initial package project definition and NuGet metadata. |
| sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/samples/Azure.ResourceManager.containerregistrytasks.Samples.csproj | Adds a samples project that references the library and dependencies. |
| sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/assets.json | Adds assets repo configuration for packaging/release automation. |
| sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/README.md | Adds initial README content for the new package. |
| sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/Directory.Build.props | Adds local Directory.Build.props to import repo-wide build settings. |
| sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/CHANGELOG.md | Adds initial changelog template for the first beta. |
| sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/Azure.ResourceManager.containerregistrytasks.sln | Adds solution file for library, samples, and tests. |
sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/README.md
Outdated
Show resolved
Hide resolved
sdk/containerregistry/Azure.ResourceManager.containerregistrytasks/README.md
Outdated
Show resolved
Hide resolved
...zure.ResourceManager.ContainerRegistryTasks/Azure.ResourceManager.ContainerRegistryTasks.sln
Outdated
Show resolved
Hide resolved
...zure.ResourceManager.ContainerRegistryTasks/Azure.ResourceManager.ContainerRegistryTasks.sln
Outdated
Show resolved
Hide resolved
...sourceManager.containerregistrytasks/src/Azure.ResourceManager.containerregistrytasks.csproj
Outdated
Show resolved
Hide resolved
...sourceManager.containerregistrytasks/src/Azure.ResourceManager.containerregistrytasks.csproj
Outdated
Show resolved
Hide resolved
...r.containerregistrytasks/samples/Azure.ResourceManager.containerregistrytasks.Samples.csproj
Outdated
Show resolved
Hide resolved
…asks/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…asks/src/Azure.ResourceManager.containerregistrytasks.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated the README to provide a brief description of the Azure Container Registry Tasks .NET client library.
…nerated SDK locally
live1206
requested changes
Mar 11, 2026
Member
live1206
left a comment
live1206
left a comment
There was a problem hiding this comment.
PR Review: Azure.ResourceManager.ContainerRegistryTasks
Phase 1: Versioning ✅
- Version
1.0.0-beta.1— new package, first beta. No issues. - No
ApiCompatVersion— expected for a brand new package. - No
ApiCompatBaseline.txt— good.
Phase 2: API Review ❌
Found 12 issues across naming conventions, type correctness, and API design patterns. See inline comments for details.
Key issues:
- Contextual Naming (Critical): ~14 types have generic names that lack service-context prefix, making them ambiguous across services.
- Custom Identity Types: Should use standard
ManagedServiceIdentityfromAzure.ResourceManager.Modelsinstead of customIdentityProperties. - Type Correctness: Several properties use
stringwhereResourceIdentifier,AzureLocation, orUriis appropriate. - Unflattened Properties: Data models expose a single
Propertiesbag instead of flattening properties directly. - Property Naming: Duration properties missing units, boolean property without verb prefix, enum values with incorrect casing.
Phase 3: Breaking Changes ⏭️
Skipped — no prior stable version exists (ApiCompatVersion not present).
12 inline comments added.
...nerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/Credentials.cs
Outdated
Show resolved
Hide resolved
...stry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/IdentityProperties.cs
Show resolved
Hide resolved
...try/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/AgentPoolProperties.cs
Outdated
Show resolved
Hide resolved
sdk/containerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/TaskRunData.cs
Outdated
Show resolved
Hide resolved
...gistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/SourceProperties.cs
Outdated
Show resolved
Hide resolved
...tainerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/AuthInfo.cs
Show resolved
Hide resolved
...stry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/DockerBuildContent.cs
Outdated
Show resolved
Hide resolved
...gistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/SecretObjectType.cs
Outdated
Show resolved
Hide resolved
...stry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/SourceTriggerEvent.cs
Outdated
Show resolved
Hide resolved
...rregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/RunProperties.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...tainerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/Argument.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
sdk/containerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/OS.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...erregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/Architecture.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...ntainerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/Variant.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...istry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/ProvisioningState.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...tainerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/SetValue.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...erregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/SecretObject.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...ainerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/TokenType.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...ntainerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/RunType.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...ainerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/RunStatus.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...inerregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/TaskStatus.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Mar 11, 2026
...rregistry/Azure.ResourceManager.ContainerRegistryTasks/src/Generated/Models/TriggerStatus.cs
Outdated
Show resolved
Hide resolved
…s for timeout properties
live1206
reviewed
Mar 12, 2026
sdk/containerregistry/Azure.ResourceManager.ContainerRegistryTasks/CHANGELOG.md
Outdated
Show resolved
Hide resolved
live1206
approved these changes
Mar 12, 2026
…m ContainerRegistryTasks solution
live1206
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/RegistryTasks/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '3f223d61b02c0496581dfb71c78104761b448d5e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5780622 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2a608315-60f6-f011-8406-000d3a376cbb Submitted by: clarkporter@microsoft.com
Release Plan Details
Spec pull request: [Typespec Migration] migrate control plane containerregistry to typespec azure-rest-api-specs#37169
Spec API version: 2025-03-01-preview