Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Azure.ResourceManager.Attestation SDK from the autorest-based generator to the Management Plane Generator (MPG/TypeSpec). The PR includes updates to both the data plane SDK (to suppress obsolete warnings) and the resource manager SDK (complete regeneration with TypeSpec).
Changes:
- Suppression of SYSLIB0057 warnings in data plane SDK for X509Certificate2 usage
- Complete regeneration of resource manager SDK using TypeSpec
- Test updates to reflect API changes in the generated code
- Addition of tsp-location.yaml configuration file
Reviewed changes
Copilot reviewed 16 out of 103 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PolicyCertificatesResult.cs, AttestationSigner.cs, AttestationToken.cs, AttestationAdministrationClient.cs | Added pragma warnings to suppress SYSLIB0057 for obsolete X509Certificate2 constructor usage |
| tsp-location.yaml | New TypeSpec configuration file specifying the spec location and generator settings |
| Test files (PrivateEndpointConnectionTests.cs, AttestationProviderTest.cs, ResourceDataHelper.cs) | Updated to use new property names (ConnectionState → PrivateLinkServiceConnectionState, AttestationProviderCreateOrUpdateContent → AttestationServiceCreationParams) |
| Sample files | Updated to reflect API changes including method name changes and return type changes |
| Generated model files | Complete regeneration with new serialization patterns, property structures, and helper classes |
| Internal helper files | New internal helper classes for serialization, pagination, and type formatting |
| LongRunningOperation files | Updated to use new Azure SDK patterns |
| Collection results | New pageable collection implementation classes |
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...on/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
...testation/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.net10.0.cs
Outdated
Show resolved
Hide resolved
...testation/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.net10.0.cs
Outdated
Show resolved
Hide resolved
sdk/attestation/Azure.Security.Attestation/src/Models/AttestationSigner.cs
Show resolved
Hide resolved
sdk/attestation/Azure.ResourceManager.Attestation/src/Generated/Models/PrivateEndpoint.cs
Outdated
Show resolved
Hide resolved
.../Azure.ResourceManager.Attestation/src/Generated/AttestationPrivateEndpointConnectionData.cs
Outdated
Show resolved
Hide resolved
| List<X509Certificate2> certificates = new List<X509Certificate2>(); | ||
| foreach (var cert in token.GetBody<PolicyCertificatesResult>().InternalPolicyCertificates.Keys) | ||
| { | ||
| #pragma warning disable SYSLIB0057 // Type or member is obsolete |
There was a problem hiding this comment.
Please don't do this - ESPECIALLY for obsolete members. In this case, the fix is easy and should be made as part of this PR. After, please file an issue for the Attestation team (marked "Service Attention") to follow-up and review before their next release.
| List<X509Certificate2> certificates = new List<X509Certificate2>(); | ||
| foreach (var certificate in Header.X509CertificateChain) | ||
| { | ||
| #pragma warning disable SYSLIB0057 // Type or member is obsolete |
| int i = 0; | ||
| foreach (var base64Cert in base64certificates) | ||
| { | ||
| #pragma warning disable SYSLIB0057 // Type or member is obsolete |
TSP PR: Azure/azure-rest-api-specs#39250 (merged)
TSP PR: Azure/azure-rest-api-specs#40223
Fixes #54478
Blocked by
markAsPageabledecorator typespec-azure#3650The main issues are as follows:
AttestationPrivateEndpointConnectionResource. Tried renaming and handling on the client side, but it still was not generated.The id parameter type cannot be converted fromstringtoAzure.Core.ResourceIdentifier, which means that the type currently being generated isstring.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.