MPG migration - ServiceNetworking#54422
Merged
ArthurMa1978 merged 30 commits intoAzure:mainfrom Jan 7, 2026
Merged
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
mzhongl524
changed the title
Member
|
seems need to re-record the test |
…zhongl524/azure-sdk-for-net into pr-service-networking-from-tsp
…ng-from-tsp' into pr-service-networking-from-tsp
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the ServiceNetworking SDK from the legacy code generator to the new Management Plane Generator (MPG/TypeSpec). The migration updates the code generation configuration, fixes test code patterns, and regenerates all SDK code with the new generator.
Key changes:
- Updated code generator configuration to use the new Azure TypeSpec HTTP client management emitter
- Fixed async/await patterns in test code (replacing
.Resultwithawait) - Fixed return type of helper methods from
async voidtoasync Task - Added property initialization workarounds for serialization
- Regenerated all SDK code with new generator patterns
Reviewed changes
Copilot reviewed 15 out of 135 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updated to use new management generator emitter and updated commit hash |
| TrafficControllerTests.cs | Fixed async patterns, added property initialization workarounds, changed method return types |
| TrafficControllerResource.cs | Regenerated with new generator - updated patterns and structure |
| TrafficControllerResource.Serialization.cs | Updated serialization implementation |
| TrafficControllerFrontendResource.cs | Regenerated with new generator patterns |
| TrafficControllerFrontendResource.Serialization.cs | Updated serialization implementation |
| TrafficControllerFrontendData.cs | Updated data model with new property pattern |
| TrafficControllerFrontendData.Serialization.cs | Updated serialization with new patterns |
| TrafficControllerFrontendCollection.cs | Regenerated collection implementation |
| TrafficControllerData.cs | Updated data model with property wrapper pattern |
| TrafficControllerData.Serialization.cs | Updated serialization implementation |
| TrafficControllerCollection.cs | Regenerated collection with new patterns |
| TrafficControllerAssociationResource.cs | Regenerated with new generator patterns |
| TrafficControllerAssociationResource.Serialization.cs | Updated serialization implementation |
| TrafficControllerAssociationData.cs | Updated data model structure |
| TrafficControllerAssociationData.Serialization.cs | Updated serialization patterns |
| ProviderConstants.cs | Minor update to class modifier |
| WafSecurityPolicy.cs | New generated model file |
| WafSecurityPolicy.Serialization.cs | New serialization for WAF model |
| WafPolicy.cs | New generated model file |
| WafPolicy.Serialization.cs | New serialization for WAF model |
| TrafficControllerUpdateProperties.cs | Updated internal data structure |
| CodeGenMemberAttribute.cs | New internal attribute for code generation |
…ng-from-tsp' into pr-service-networking-from-tsp
ArthurMa1978
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: #53900
TSP PR: Azure/azure-rest-api-specs#39161
Use the new code generator to generate SDK code from TSP.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.