[Grafana] Verify that the new code generator generates SDK code from TSP#54273
Merged
ArthurMa1978 merged 6 commits intoAzure:mainfrom Jan 4, 2026
Merged
[Grafana] Verify that the new code generator generates SDK code from TSP#54273ArthurMa1978 merged 6 commits intoAzure:mainfrom
ArthurMa1978 merged 6 commits intoAzure:mainfrom
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Grafana SDK from the legacy code generator to the new Azure Management Generator by updating the TSP configuration to use the new emitter package. The changes include regenerated code with updated patterns for REST operations, models, and serialization logic.
Key Changes:
- Updated emitter configuration to use the new Azure TypeSpec management emitter
- Regenerated all REST operation classes with new naming conventions and structure
- Updated model serialization patterns across multiple classes
- Added new model classes for private endpoint functionality
Reviewed changes
Copilot reviewed 7 out of 199 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updated emitter package reference to new management generator |
| PrivateLinkResourcesRestOperations.cs | Refactored class structure with new naming and protocol method patterns |
| PrivateEndpointConnectionsRestOperations.cs | Similar refactoring to use new generator patterns |
| ManagedPrivateEndpointModelsRestOperations.cs | Updated to new REST operations structure |
| ManagedGrafanasRestOperations.cs | Comprehensive refactoring with new method signatures |
| ManagedDashboardsRestOperations.cs | Updated REST operations with protocol methods |
| IntegrationFabricsRestOperations.cs | Regenerated with new generator patterns |
| DashboardDefinitionsRestOperations.cs | New file added by generator |
| ProviderConstants.cs | Minor modifier change (internal static → internal static partial) |
| Various Model files | Updated serialization patterns and field naming conventions |
ArthurMa1978
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: #53880
TPS PR: Azure/azure-rest-api-specs#39052
Use the new code generator to generate SDK code from TSP.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.