Skip to content

Hide obsolete property from API ref docs and IntelliSense#53126

Merged
JonathanCrd merged 3 commits intomainfrom
scottaddie/identity-browser-customization
Oct 10, 2025
Merged

Hide obsolete property from API ref docs and IntelliSense#53126
JonathanCrd merged 3 commits intomainfrom
scottaddie/identity-browser-customization

Conversation

@scottaddie
Copy link
Copy Markdown
Member

In an effort to discourage further use, we don't want this obsolete property to appear in IntelliSense. The API ref docs also aren't worth publishing.

Copilot AI review requested due to automatic review settings October 9, 2025 22:07
@scottaddie scottaddie requested review from a team and JonathanCrd as code owners October 9, 2025 22:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR hides an obsolete property from IntelliSense and API reference documentation to discourage its continued use.

  • Added [EditorBrowsable(EditorBrowsableState.Never)] attribute to hide the property from IntelliSense
  • Fixed punctuation in the obsolete attribute message by adding a missing period

Copy link
Copy Markdown
Member

@JonathanCrd JonathanCrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also requires to update the API files too by running the ExportAPI script

@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure Identity SDK Improvements Oct 10, 2025
@JonathanCrd JonathanCrd marked this pull request as ready for review October 10, 2025 17:20
@JonathanCrd JonathanCrd enabled auto-merge (squash) October 10, 2025 18:31
@JonathanCrd JonathanCrd merged commit 99c70de into main Oct 10, 2025
17 checks passed
@JonathanCrd JonathanCrd deleted the scottaddie/identity-browser-customization branch October 10, 2025 19:02
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure Identity SDK Improvements Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants