Fix function definition equality and expose ServerLabel.#53085
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the implementation of equality comparison for FunctionToolDefinition by ensuring the GetHashCode method is consistent with the Equals method.
- Updates GetHashCode() to use Name.GetHashCode() instead of InternalFunction.GetHashCode()
- Adds comprehensive unit tests to verify equality behavior across different name and description combinations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Custom/FunctionToolDefinition.cs | Fixed GetHashCode implementation to be consistent with Equals method |
| tests/UnitTests.cs | Added unit test to verify function definition equality behavior |
nick863
force-pushed
the
nirovins/function_definition_eq
branch
from
bc7f22e to
765badf
Compare
nick863
force-pushed
the
nirovins/function_definition_eq
branch
from
765badf to
52b9080
Compare
nick863
changed the title
nick863
changed the title
…o nirovins/function_definition_eq
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
dargilco
approved these changes
Oct 10, 2025
Contributor
|
@jozkee, fyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
See: #53043 and #53001
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.