Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the naming of properties in the MCPApproval class to better reflect their actual behavior. The properties were renamed from AlwaysApprove/NeverApprove to AlwaysRequireApproval/NeverRequireApproval to clarify that they indicate when approval is required, not when it's automatically granted.
Key changes:
- Renamed
AlwaysApprovetoAlwaysRequireApprovalandNeverApprovetoNeverRequireApproval - Updated all test references to use the new property names
- Updated API surface files to reflect the breaking change
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/Azure.AI.Agents.Persistent/src/Custom/MCPApproval.cs | Renamed properties and updated internal logic to use new names |
| sdk/ai/Azure.AI.Agents.Persistent/tests/UnitTests.cs | Updated all test assertions to reference the renamed properties |
| sdk/ai/Azure.AI.Agents.Persistent/api/Azure.AI.Agents.Persistent.netstandard2.0.cs | Updated API surface to reflect the property name changes |
| sdk/ai/Azure.AI.Agents.Persistent/api/Azure.AI.Agents.Persistent.net8.0.cs | Updated API surface to reflect the property name changes |
| sdk/ai/Azure.AI.Agents.Persistent/CHANGELOG.md | Added changelog entry documenting the naming fix |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
dargilco
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
See issue
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.