Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for async operations in image processing tests and documents a bug fix related to image block serialization in async scenarios. The changes ensure that both synchronous and asynchronous code paths are properly tested.
Key Changes
- Modified test method to use async operations where appropriate
- Added conditional logic to test both sync and async message creation methods
- Updated changelog to document the image serialization bug fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
PersistentAgentsTests.cs |
Added async thread creation and conditional async/sync message creation logic with TODO comment |
CHANGELOG.md |
Added changelog entry for image block serialization bug fix |
dargilco
approved these changes
Oct 8, 2025
…o nirovin/add_changelog_test
…o nirovin/add_changelog_test
dargilco
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
See #52671
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.