[ComputerVision] Add Brand Analysis test case#5305
[ComputerVision] Add Brand Analysis test case#5305cthrash wants to merge 6 commits intoAzure:masterfrom
Conversation
Updating header
|
@azuresdkci Test this please |
|
@cthrash master is our default branch now, please resolve conflicts and update the pr |
There was a problem hiding this comment.
Can't see any changes to the SDK itself, please regenerate the code if needed.
Else, please confirm you wish to publish a Nuget with no new changes in the SDK.
There was a problem hiding this comment.
Yeah, forgot that the new generated code wasn't auto-generated on commit to azure-rest-api-specs. Added
cthrash
force-pushed
the
cthrash/computervision-analyze-brand
branch
from
ba81ac9 to
adb4b7c
Compare
|
|
||
| // <auto-generated> | ||
| // Code generated by Microsoft (R) AutoRest Code Generator. | ||
| // Changes may cause incorrect behavior and will be lost if the code is |
There was a problem hiding this comment.
Please regenerate the code using generate.ps1 script, this file should not be deleted
| /// </param> | ||
| /// <param name='disposeHttpClient'> | ||
| /// True: will dispose the provided httpClient on calling ComputerVisionClient.Dispose(). False: will not dispose provided httpClient</param> | ||
| protected ComputerVisionClient(HttpClient httpClient, bool disposeHttpClient) : base(httpClient, disposeHttpClient) |
There was a problem hiding this comment.
This could be a breaking change. Was this code generated using generate.ps1
There was a problem hiding this comment.
It was generated by generate.ps1, and I can only presume this is a change in how autorest generates the code.
I'd have to poke around to see what may have changed. These are the versions used:
AutoRest code generation utility [version: 2.0.4283; node: v8.9.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core 'C:\Users\cthrash.REDMOND\.autorest\@microsoft.azure_autorest-core@2.0.4302\node_modules\@microsoft.azure\autorest-core\dist' (2.0.4302)
Loading AutoRest extension '@microsoft.azure/autorest.csharp' (~2.3.79->2.3.79)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.55->2.3.55)
2019-03-04 21:43:41 UTC
Azure-rest-api-specs repository information
GitHub fork: Azure
Branch: master
Commit: 1e7a3ce32b5ed2ecf968507eb3388aa07fbaff81
AutoRest information
Requested version: latest
Bootstrapper version: autorest@2.0.4283
There was a problem hiding this comment.
Could you try running autorest --reset and regenerate the code again.
There was a problem hiding this comment.
I was branching off the old psSdkJson6 branch. An updated PR has been made, this one will be abandoned
There was a problem hiding this comment.
Please close this PR when ready and reference it in the new PR
3 participants
Test update for Azure/azure-rest-api-specs#5141
Also fix RecognizeText test fix; output changed due to model upgrade.