[Azure Search] Generate code for the Index and Suggest APIs#5303
Merged
brjohnstmsft merged 8 commits intoAzure:search-previewfrom Mar 5, 2019
Merged
[Azure Search] Generate code for the Index and Suggest APIs#5303brjohnstmsft merged 8 commits intoAzure:search-previewfrom
brjohnstmsft merged 8 commits intoAzure:search-previewfrom
Conversation
…ernal Also made AutocompleteRequest internal. All the *Request classes are implementation details that never should have been public. Also fixed some erroneous documentation.
From now on, for dynamically-typed scenarios, callers of Suggest need to use DocumentSuggestResult<Document> and SuggestResult<Document> instead. This will make it easier to transition the implementation of this API to generated code.
…asses These classes are not really necessary since you can always use IndexAction<Document> and IndexBatch<Document> instead. Removing them will make it easier to replace the implementation of the Index API with generated code. This is a breaking change.
This includes the custom model classes IndexBatch and IndexAction as well.
Member
|
Is it by design that the Generated metadata points to your fork and not the public Azure repo? |
Member
Author
|
@arv100kri Yes, thanks for reminding me. I still need to update that. Will push another commit in a little while. Also, the [DO NOT MERGE] is to let azure-sdk-for-net maintainers know that we (Azure Search team) will take care of merging this, since it targets the search-preview branch. |
arv100kri
reviewed
Mar 1, 2019
...ne/Microsoft.Azure.Search.Data/Customizations/Documents/DocumentsOperations.Customization.cs
Show resolved
Hide resolved
arv100kri
approved these changes
Mar 1, 2019
Contributor
|
LGTM |
brjohnstmsft
changed the title
|
sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding Swagger PR: Azure/azure-rest-api-specs#5219
This change replaces a bunch of custom code with generated code, specifically for the Index and Suggest APIs.
There are some breaking changes:
We have already bumped the major SDK version in anticipation of these breaking changes.
Big thanks to @mhko who did the majority of the work on this.
FYI @arv100kri @Yahnoosh