Fix CreateMessageAsync to properly serialize the content blocks #53018
+17
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse the same fix as was previously applied for CreateMessage
stephentoub
requested review from
dargilco,
glharper and
nick863
as code owners
github-actions
bot
added
AI Model Inference
AI Projects
Community Contribution
There was a problem hiding this comment.
Pull Request Overview
Fixes incorrect serialization in CreateMessageAsync by reusing the same JSON serialization logic as the synchronous CreateMessage method. Extracts the shared serialization logic into a new private helper to eliminate duplication and correct the earlier bug.
- Refactors duplicated serialization logic into ConvertMessageInputContentBlocksToJson.
- Corrects async path to serialize the produced JsonElements instead of the original content block objects.
|
Thank you for your contribution @stephentoub! We will review the pull request and get back to you soon. |
nick863
approved these changes
Oct 6, 2025
crickman
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the same fix as was previously applied for CreateMessage
Fixes #52671