-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[AzureMonitorExporter] Part 2 - Customer sdkstats - Implementation + Tests #53010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AzureMonitorExporter] Part 2 - Customer sdkstats - Implementation + Tests #53010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements customer SDK statistics tracking functionality as part 2 of the Azure Monitor Exporter customer SDK stats feature. The implementation adds telemetry counting, success/failure tracking, and statistical reporting throughout the telemetry processing pipeline.
Key changes include:
- Added
TelemetrySchemaTypeCounterto track different telemetry types (request, dependency, exception, etc.) - Modified helper methods to return both telemetry items and counters as tuples
- Updated all exporters and transmitters to pass counter information through the pipeline
- Enhanced transmission result processing to track successes, failures, retries, and drops with detailed categorization
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TelemetrySchemaTypeCounter.cs | Renamed class from TelemetryCounter to TelemetrySchemaTypeCounter |
| CustomerSdkStatsHelper.cs | Updated method parameters to use renamed counter class |
| OpenTelemetryBuilderExtensions.cs | Added customer SDK stats registration and reordered imports |
| TraceHelper.cs | Modified to return tuple with counter, added counter increment logic |
| MetricHelper.cs | Modified to return tuple with counter for metric tracking |
| LogsHelper.cs | Modified to return tuple with counter, added counter increment logic |
| ITransmitter.cs | Updated interface to include counter parameter |
| HttpPipelineHelper.cs | Enhanced with counter tracking, JSON parsing, and detailed transmission result processing |
| TransmitFromStorageHandler.cs | Added counter tracking for storage transmission scenarios |
| AzureMonitorTransmitter.cs | Updated to use counter parameter and track transmission outcomes |
| All Exporter classes | Updated to handle tuple return values and pass counters |
| Test files | Updated to handle new tuple return values and validate counter behavior |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.