-
Notifications
You must be signed in to change notification settings - Fork 5k
[AutoPR Azure.ResourceManager.StorageDiscovery]-generated-from-SDK Generation - .NET-5414958 #53005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[AutoPR Azure.ResourceManager.StorageDiscovery]-generated-from-SDK Generation - .NET-5414958 #53005
Conversation
…overy.Management/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c5830522fede113ee777dc4525c80a28d1a7a264' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5414958 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Released version 1.0.0 of Azure Storage Discovery client library with stable API surface and core features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is an auto-generated pull request that promotes the Azure Storage Discovery Resource Manager SDK from beta to stable (GA) release, updating the version from 1.0.0-beta.2 to 1.0.0 and updating the TypeSpec configuration.
- Version bump from 1.0.0-beta.2 to 1.0.0 (stable release)
- Updated TypeSpec configuration with new commit SHA and formatting changes
- Updated installation instructions to remove the --prerelease flag
- Added comprehensive changelog entry for the GA release
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
tsp-location.yaml | Updates TypeSpec configuration commit SHA and formats the emitter package path |
Azure.ResourceManager.StorageDiscovery.csproj | Promotes package version from 1.0.0-beta.2 to 1.0.0 |
README.md | Removes --prerelease flag from installation instructions |
CHANGELOG.md | Adds GA release entry with feature descriptions and removes unreleased beta section |
This pr is re-generated after this fix SDK Generation - .NET failing after updated to "@azure-typespec/http-client-csharp-mgmt". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple comments on the apiview here https://spa.apiview.dev/review/0740011866cd42459df0452e8359a78e?activeApiRevisionId=0734d4ad96984025bb625b5e82a9d835
<Version>1.0.0-beta.2</Version> | ||
<Version>1.0.0</Version> | ||
<PackageTags>azure;management;arm;resource manager;storagediscovery</PackageTags> | ||
<PackageId>Azure.ResourceManager.StorageDiscovery</PackageId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add CheckAOTCompat: true
to the ci.yml and
<IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
To a PropertyGroup in the csproj
Configurations: 'specification/storagediscovery/Microsoft.StorageDiscovery.Management/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c5830522fede113ee777dc4525c80a28d1a7a264' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5414958 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=7a1107dd-d78c-f011-b4cc-6045bd07ef68 Submitted by: [email protected]
Release Plan Details
Spec pull request: enable new mpg emitter for storagediscovery azure-rest-api-specs#37783
Spec API version: 2025-09-01