Skip to content

Conversation

azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Oct 3, 2025

Configurations: 'specification/storagediscovery/Microsoft.StorageDiscovery.Management/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c5830522fede113ee777dc4525c80a28d1a7a264' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5414958 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=7a1107dd-d78c-f011-b4cc-6045bd07ef68 Submitted by: [email protected]

Release Plan Details

…overy.Management/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c5830522fede113ee777dc4525c80a28d1a7a264' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5414958 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Oct 3, 2025
@shanefujs shanefujs marked this pull request as ready for review October 3, 2025 17:35
@Copilot Copilot AI review requested due to automatic review settings October 3, 2025 17:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is an auto-generated pull request that promotes the Azure Storage Discovery Resource Manager SDK from beta to stable (GA) release, updating the version from 1.0.0-beta.2 to 1.0.0 and updating the TypeSpec configuration.

  • Version bump from 1.0.0-beta.2 to 1.0.0 (stable release)
  • Updated TypeSpec configuration with new commit SHA and formatting changes
  • Updated installation instructions to remove the --prerelease flag
  • Added comprehensive changelog entry for the GA release

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tsp-location.yaml Updates TypeSpec configuration commit SHA and formats the emitter package path
Azure.ResourceManager.StorageDiscovery.csproj Promotes package version from 1.0.0-beta.2 to 1.0.0
README.md Removes --prerelease flag from installation instructions
CHANGELOG.md Adds GA release entry with feature descriptions and removes unreleased beta section

@shanefujs shanefujs requested a review from m-nash October 3, 2025 17:51
@shanefujs
Copy link
Member

Copy link
Member

@m-nash m-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Version>1.0.0-beta.2</Version>
<Version>1.0.0</Version>
<PackageTags>azure;management;arm;resource manager;storagediscovery</PackageTags>
<PackageId>Azure.ResourceManager.StorageDiscovery</PackageId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add CheckAOTCompat: true to the ci.yml and

    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>

To a PropertyGroup in the csproj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants