Microsoft.Maps management plane 2025-10-01-preview updates. #52984
Conversation
map-blasterson
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Maps management plane tests to use the new 2025-10-01-preview API version. The main change is migrating from the deprecated MapsSkuName.S0 SKU to MapsSkuName.G2 after the S0 SKU was removed from the new API version.
Key changes:
- Replace all instances of
MapsSkuName.S0withMapsSkuName.G2in test assertions - Remove SKU update test logic that was testing S0 to S1 transitions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/maps/Azure.ResourceManager.Maps/tests/ScenarioTests/MapsAccountTests.cs | Updates test assertions to use G2 SKU instead of deprecated S0 SKU, removes S1 SKU update test logic |
| sdk/maps/Azure.ResourceManager.Maps/tests/MapsManagementTestBase.cs | Updates default SKU assertion in test verification helper method from S0 to G2 |
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @map-blasterson! We will review the pull request and get back to you soon. |
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
Your account lacks the public GitHub organization memberships and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
Made memberships public. I don't intend to be code owner going forward, I'm only here to unblock a specs PR. |
map-blasterson
added
Maps
and removed
customer-reported
|
@jsquire Can you take a look at this today? |
I can confirm that your account issues have been resolved. You'll need Arthur and team for review of the management library code. |
3 participants
Contributing to the Azure SDK
New api-version removes
MapsSkuName.S0which causes these tests to fail.Updating tests to use the latest SKU.