Merged
Conversation
yangyuan
approved these changes
Feb 26, 2019
Member
yangyuan
left a comment
yangyuan
left a comment
There was a problem hiding this comment.
LGTM except version and release notes.
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
Contributor
|
Please link the rest spec PR |
dsgouda
suggested changes
Feb 27, 2019
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
Outdated
Show resolved
Hide resolved
parent e68ceb4 author Lakshmanan Ramu Meenal <laramume@microsoft.com> 1539635490 -0700 committer Lakshmanan Ramu Meenal <laramume@microsoft.com> 1551313811 -0800 # This is a combination of 2 commits. # This is the 1st commit message: added 2.1 preview SDK for text analytics based on PR commanets changed the number of SDK's to one # This is the commit message #1: fixed test project errors # This is the commit message Azure#2: fixed test project errors # This is the commit message Azure#3: fixed test project errors # This is the commit message Azure#4: fixed the log errors
laramume
force-pushed
the
users/laramume/TAV2.1
branch
from
87bb245 to
53123d7
Compare
dsgouda
suggested changes
Mar 5, 2019
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks great apart from a minor change
|
|
||
| [assembly: AssemblyVersion("2.0.0.0")] | ||
| [assembly: AssemblyVersion("3.0.0.0")] | ||
| [assembly: AssemblyFileVersion("2.1.0.0")] |
Contributor
There was a problem hiding this comment.
Please update AssemblyFileVersion too
Contributor
|
Will merge once CIs pass |
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
* # This is a combination of 5 commits. parent e68ceb4 author Lakshmanan Ramu Meenal <laramume@microsoft.com> 1539635490 -0700 committer Lakshmanan Ramu Meenal <laramume@microsoft.com> 1551313811 -0800 # This is a combination of 2 commits. # This is the 1st commit message: added 2.1 preview SDK for text analytics based on PR commanets changed the number of SDK's to one # This is the commit message Azure#1: fixed test project errors # This is the commit message Azure#2: fixed test project errors # This is the commit message Azure#3: fixed test project errors # This is the commit message Azure#4: fixed the log errors * changed the version name and package notes * # This is a combination of 5 commits. # This is the 1st commit message: added SDK for version 2.1 # This is the commit message Azure#1: resolved build failure # This is the commit message Azure#2: resolved build failure # This is the commit message Azure#3: resolved build failure # This is the commit message Azure#4: resolved build failure * added SDK for version 2.1 * changed version number to 3.0.0 * updated assemblyfileversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added SDK for new API version v2.1. Rest API Spec