Add cognitive service AnomalyDetector SDK with unittests#5276
Add cognitive service AnomalyDetector SDK with unittests#5276dsgouda merged 3 commits intoAzure:masterfrom moreOver0:zhuxia/anomaly_finder
Conversation
|
@yangyuan Please take a reivew except the file cognitiveservices_data-plane_AnomalyDetector.txt because it's not real log when generating code. I will update this file when Azure/azure-rest-api-specs#5295 get merged. |
src/SDKs/CognitiveServices/dataPlane/AnomalyDetector/AnomalyDetector/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
...ane/AnomalyDetector/AnomalyDetector/Microsoft.Azure.CognitiveServices.AnomalyDetector.csproj
Outdated
Show resolved
Hide resolved
...ane/AnomalyDetector/AnomalyDetector/Microsoft.Azure.CognitiveServices.AnomalyDetector.csproj
Outdated
Show resolved
Hide resolved
...ane/AnomalyDetector/AnomalyDetector/Microsoft.Azure.CognitiveServices.AnomalyDetector.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/CognitiveServices/dataPlane/AnomalyDetector/AnomalyDetector/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
moreOver0
changed the title
|
@moreOver0 please squash the commits for a cleaner commit history |
fullfill .net solution structure add unit tests update PackageReleaseNotes copy resource "PreserveNewest" change service name fix property name in response change sdk version to 1.0.0.0 update change from swagger, make non nullable update PackageReleaseNotes update swagger change re-generate code from zhuxia/ad from repo moreOver0/azure-rest-api-specs updates
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Approved in principle. Will approve and merge once the code is generated from merged REST spec
|
@AlexGhiondea can you approve this as this is dataplane PR. |
AlexGhiondea
left a comment
AlexGhiondea
left a comment
There was a problem hiding this comment.
I have a question about the package version.
| Commencing code generation | ||
| Generating CSharp code | ||
| Executing AutoRest command | ||
| cmd.exe /c autorest.cmd https://github.com/moreOver0/azure-rest-api-specs/blob/zhuxia/ad/specification/cognitiveservices/data-plane/AnomalyDetector/readme.md --csharp --version=latest --reflect-api-versions --csharp-sdks-folder=D:\src\azure-sdk-for-net\src\SDKs |
There was a problem hiding this comment.
Was this supposed to be added?
There was a problem hiding this comment.
Do you mean this line cmd.exe /c autorest.cmd https://github.com/moreOver0/azure-rest-api-specs/blob/zhuxia/ad/specification/cognitiveservices/data-plane/AnomalyDetector/readme.md --csharp --version=latest --reflect-api-versions --csharp-sdks-folder=D:\src\azure-sdk-for-net\src\SDKs ?
I generated the C# code from my own branch because my swagger PR is not merged now. I will update this after the swagger PR get merged.
There was a problem hiding this comment.
Sorry -- I was asking about the entire text file.
There was a problem hiding this comment.
I thought I should add this file. It is an auto generated log file when I use generate.ps1 to generate code. I believe this file is target to record repo, branch and commit id.
@dsgouda What do you think about this file? Should I add this file?
There was a problem hiding this comment.
@AlexGhiondea This is a log file we generate when generating the SDK using scripts. Helps us review what specs were used for it.
| <PackageTags>Azure AnomalyDetector;</PackageTags> | ||
| <PropertyGroup> | ||
| <PackageId>Microsoft.Azure.CognitiveServices.AnomalyDetector</PackageId> | ||
| <Version>0.8.0-preview</Version> |
There was a problem hiding this comment.
I see you are bumping down the version number and changing the name. Any reason to pick 0.8.0 here instead of something else (like 0.1.0)?
There was a problem hiding this comment.
@shahabhijeet merged some project structures in #5464 because he didn't aware that there already has a ready SDK PR. So I solved the conflicts after that. Please ignore all these changes.
@dsgouda suggested me to use 0.8.0-preivew in previous comments.
There was a problem hiding this comment.
@AlexGhiondea For brand new RPs we recommend starting from 0.8.0-preview so that when they are ready to release a stable version they can start from 1.0.0. we apply the same guidelines when working with the next preview versions (1.8.0-preview-2.0.0)
|
@AlexGhiondea I have answered the questions, let us know if this good to merge |
|
@dsgouda I have updated the generate.ps1 and session records since the swagger PR got merged. You can merge this PR when you and Alex think it's OK. |
|
LGTM! |
* add anomaly detector sdk with unit tests fullfill .net solution structure add unit tests update PackageReleaseNotes copy resource "PreserveNewest" change service name fix property name in response change sdk version to 1.0.0.0 update change from swagger, make non nullable update PackageReleaseNotes update swagger change re-generate code from zhuxia/ad from repo moreOver0/azure-rest-api-specs updates * update generate.ps1 and session records
5 participants
Azure/azure-rest-api-specs#5295 This is the related REST spec API PR.