Update Batch dataplane SDK dependencies#5265
Merged
shahabhijeet merged 1 commit intoAzure:masterfrom Feb 24, 2019
Merged
Conversation
shahabhijeet
suggested changes
Feb 21, 2019
Contributor
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
Looks good.
But the sooner you use the common imports, you can get rid of individual targetFx conditions you have added.
I think this is long due, now that all the TragetFx that your RP needs is now available out of the box in our repo.
I will let Alex sign off, but looks good to me.
Member
Author
|
Yeah, the TargetFx stuff is the bit I mailed you about, where I can't use the targets defined in the root targets file because we depend on our management plane SDK from nuget which doesn't target those targets yet. |
Member
Author
|
@AlexGhiondea - Ping, can we merge this? |
AlexGhiondea
approved these changes
Feb 23, 2019
shahabhijeet
approved these changes
Feb 24, 2019
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.