Adding first version of Edge gateway sdk and tests by anponnet · Pull Request #5250 · Azure/azure-sdk-for-net

anponnet · 2019-02-14T15:41:00Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

anponnet · 2019-02-14T15:42:19Z

Swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/5191/commits

anponnet · 2019-02-14T15:43:19Z

swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/5191/commits

dsgouda · 2019-02-14T17:50:03Z

@anponnet please confirm that you have joined the Azure org here

dsgouda

How was this code generated? Please create a generate.ps1 file similar to this and regenerate the code. Please commit all the changes generated.

dsgouda · 2019-02-14T17:51:21Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+  <Import Condition=" Exists('$([MSBuild]::GetPathOfFileAbove(AzSdk.test.reference.props))') " Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.test.reference.props'))" />
+  <!-- Please do not move/edit code below this line -->
+  <PropertyGroup>
+    <PackageId>Foo</PackageId>


Please rename this to EdgeGateway.Tests

Corrected using generate.ps1. Swagger was taken from the fork. https://github.com/anponnet/azure-rest-api-specs/tree/version20190301

dsgouda · 2019-02-14T17:51:57Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+  <!-- Please do not move/edit code below this line -->
+  <PropertyGroup>
+    <PackageId>Foo</PackageId>
+    <VersionPrefix>1.0.0-preview</VersionPrefix>


Please replace this with <Version>1.0.0</Version>

dsgouda · 2019-02-14T17:52:09Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+  <PropertyGroup>
+    <PackageId>Foo</PackageId>
+    <VersionPrefix>1.0.0-preview</VersionPrefix>
+    <AssemblyName>Foo</AssemblyName>


Please update the AssemblyName

dsgouda · 2019-02-14T17:52:19Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+    <PackageId>Foo</PackageId>
+    <VersionPrefix>1.0.0-preview</VersionPrefix>
+    <AssemblyName>Foo</AssemblyName>
+    <Description>BatchAI.Tests;</Description>


Incorrect name

dsgouda · 2019-02-14T17:53:35Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+    <PackageId>Foo</PackageId>
+    <VersionPrefix>1.0.0-preview</VersionPrefix>
+    <AssemblyName>Foo</AssemblyName>
+    <Description>BatchAI.Tests;</Description>


Please add the line
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
And fix errors if any

dsgouda · 2019-02-14T17:56:26Z

...Gateway/Microsoft.Azure.Management.EdgeGateway/Microsoft.Azure.Management.EdgeGateway.csproj

+    <PackageId>Microsoft.Azure.Management.EdgeGateway</PackageId>
+    <Description>Microsoft Azure Management EdgeGateway library</Description>
+    <AssemblyName>Microsoft.Azure.Management.EdgeGateway</AssemblyName>
+    <Version>1.0.0</Version>


We recommend starting versioning from 0.9.0-preview before releasing a stable version. Please confirm whether you are ready to release a stable version of the SDK?

Changed to 0.9.0-preview. May be we will release first version after 1-2 weeks

dsgouda · 2019-02-14T17:56:42Z

...Gateway/Microsoft.Azure.Management.EdgeGateway/Microsoft.Azure.Management.EdgeGateway.csproj

+        This is a public release of the Azure EdgeGateway SDK. 
+      ]]>
+    </PackageReleaseNotes>
+    <NoWarn>$(NoWarn);CS1591</NoWarn>


Any reason why this was added?

Removed the line

dsgouda

Please add AssemblyInfo.cs files for Test and Sdk projects.

anponnet · 2019-02-15T10:14:03Z

@dsgouda I am part of azure org

…use generate.ps1

dsgouda · 2019-02-15T17:15:34Z

...Gateway/Microsoft.Azure.Management.EdgeGateway/Microsoft.Azure.Management.EdgeGateway.csproj

+  </PropertyGroup>
+
+  <PropertyGroup>
+    <TargetFrameworks>net452;netstandard1.4</TargetFrameworks>


Please replace this with <TargetFrameworks>$(SdkTargetFx)</TargetFrameworks>

dsgouda · 2019-02-15T17:15:56Z

...Gateway/Microsoft.Azure.Management.EdgeGateway/Microsoft.Azure.Management.EdgeGateway.csproj

+
+  <PropertyGroup>
+    <TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
+    <RootNamespace>Microsoft.Azure.Management.EdgeGateway</RootNamespace>


Don't think this line is needed

dsgouda · 2019-02-15T17:16:18Z

...Gateway/Microsoft.Azure.Management.EdgeGateway/Microsoft.Azure.Management.EdgeGateway.csproj

+
+  <!-- Please do not move/edit code below this line -->
+  <Import Condition=" Exists('$([MSBuild]::GetPathOfFileAbove(AzSdk.RP.props))') " Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.RP.props'))" />
+  <ItemGroup>


Please remove this ItemGroup

dsgouda · 2019-02-15T17:17:03Z

src/SDKs/EdgeGateway/Microsoft.Azure.Management.EdgeGateway/Properties/AssemblyInfo.cs

+[assembly: AssemblyTitle("Microsoft Azure DataBox Edge Gateway Management Library")]
+[assembly: AssemblyDescription("Provides management functionality for Microsoft Azure DataBox Edge Gateway Management Resources.")]
+
+[assembly: AssemblyVersion("1.0.0.0")]


AssemblyVersion must also be 0.9.0.0

dsgouda · 2019-02-15T17:18:56Z

src/SDKs/StorSimple/Series1200/Management.StorSimple1200Series/generate.ps1

@@ -1 +1,2 @@
 Start-AutoRestCodeGeneration -ResourceProvider "storSimple1200Series\resource-manager" -AutoRestVersion "latest" -SdkGenerationDirectory�"$PSScriptRoot\Generated"  
+


Please undo changes to this file

dsgouda · 2019-02-15T17:20:54Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|netcoreapp2.0|AnyCPU'">
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <WarningsAsErrors />


Remove lines 16 and 17

dsgouda · 2019-02-15T17:21:38Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+  <ItemGroup>
+    <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
+  </ItemGroup>
+  <ItemGroup>


Please use a regex like SessionRecords\**\*.json instead

…es in proj files

dsgouda

Looks great apart from a couple of minor corrections

dsgouda · 2019-02-15T19:15:20Z

src/SDKs/EdgeGateway/Microsoft.Azure.Management.EdgeGateway/Properties/AssemblyInfo.cs


-[assembly: AssemblyVersion("1.0.0.0")]
+[assembly: AssemblyVersion("0.9.0.0")]
 [assembly: AssemblyFileVersion("1.0.0.0")]


Please fix AssemblyFileVersion too.

dsgouda · 2019-02-15T19:16:30Z

src/SDKs/EdgeGateway/Microsoft.Azure.Management.EdgeGateway/Properties/AssemblyInfo.cs

 [assembly: AssemblyDescription("Provides management functionality for Microsoft Azure DataBox Edge Gateway Management Resources.")]

-[assembly: AssemblyVersion("1.0.0.0")]
+[assembly: AssemblyVersion("0.9.0.0")]


I probably misspoke earlier, we start versioning for new packages from 0.8.0-preview
Please update the csproj and this file to set all versions to 0.8.0 (-preview in the csproj)

dsgouda

Also, please rename the directory Microsoft.Azure.Management.EdgeGateway to Management.EdgeGateway for consistency

dsgouda

Approving in principle, will merge once Rest spec is merged and code is regenerated

dsgouda

Please remove the $(SdkTargetFx) file

anponnet · 2019-02-19T09:10:31Z

Please remove the $(SdkTargetFx) file

@dsgouda I did not understand the comment. Should I remove generate.ps1 file?

…st spec

anponnet · 2019-02-19T10:16:48Z

@dsgouda : Rest spec is merged and code is regenerated

dsgouda · 2019-02-19T17:28:16Z

@anponnet can you check if you have joined the Azure org here

dsgouda · 2019-02-19T17:45:34Z

@azuresdkci Test this please

dsgouda · 2019-02-19T18:52:01Z

@anponnet please note that we have switched our base branch to master. That was the problem here.

dsgouda

Please delete the file $(SdkTargetFx)

dsgouda · 2019-02-19T18:53:32Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+  <PropertyGroup>
+    <TargetFrameworks>netcoreapp2.0</TargetFrameworks>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|netcoreapp2.0|AnyCPU'">


Please remove these conditions

dsgouda · 2019-02-19T18:53:55Z

src/SDKs/EdgeGateway/EdgeGateway.Tests/EdgeGateway.Tests.csproj

+  <!-- Please do not move/edit code below this line -->
+  <PropertyGroup>
+    <PackageId>EdgeGateway.Tests</PackageId>
+    <VersionPrefix>1.0.0</VersionPrefix>


Please replace VersionPrefix with Version

dsgouda · 2019-02-19T18:55:39Z

src/SDKs/EdgeGateway/Management.EdgeGateway/Microsoft.Azure.Management.EdgeGateway.csproj

+    <PackageTags>Microsoft Azure EdgeGateway management;EdgeGateway;EdgeGateway management;</PackageTags>
+    <PackageReleaseNotes>
+      <![CDATA[
+        This is a public release of the Azure EdgeGateway SDK. 


nit: "public preview release"

dsgouda

LGTM will merge once CIs pass

* Adding first version of Edge gateway sdk and tests * Fixing PR comments - Project property corrections, add assemblyinfo, use generate.ps1 * Fix PR comments - assemblyinfo, assemblyversion, unnecassary properties in proj files * PR comment fixes: Target framework, folder structure * Updated device updates test case * Regenerated client code with generate.ps1 pointing to azure master rest spec * PR Comments: project property fixes, rerun tests

Adding first version of Edge gateway sdk and tests

eacb7f7

dsgouda suggested changes Feb 14, 2019

View reviewed changes

dsgouda added the Changes Requested label Feb 14, 2019

dsgouda suggested changes Feb 14, 2019

View reviewed changes

Fixing PR comments - Project property corrections, add assemblyinfo, …

086558c

…use generate.ps1

dsgouda suggested changes Feb 15, 2019

View reviewed changes

dsgouda added the spec-not-merged label Feb 15, 2019

Fix PR comments - assemblyinfo, assemblyversion, unnecassary properti…

73d8947

…es in proj files

dsgouda suggested changes Feb 15, 2019

View reviewed changes

PR comment fixes: Target framework, folder structure

8c6919b

dsgouda removed the Changes Requested label Feb 15, 2019

dsgouda reviewed Feb 15, 2019

View reviewed changes

anponnet added 2 commits February 19, 2019 14:50

Updated device updates test case

d81ea39

Regenerated client code with generate.ps1 pointing to azure master re…

57e1f10

…st spec

dsgouda removed the spec-not-merged label Feb 19, 2019

dsgouda changed the base branch from psSdkJson6 to master February 19, 2019 18:51

dsgouda suggested changes Feb 19, 2019

View reviewed changes

PR Comments: project property fixes, rerun tests

6ec1d5b

dsgouda approved these changes Feb 20, 2019

View reviewed changes

dsgouda merged commit bf60664 into Azure:master Feb 20, 2019

		@@ -1 +1,2 @@
		Start-AutoRestCodeGeneration -ResourceProvider "storSimple1200Series\resource-manager" -AutoRestVersion "latest" -SdkGenerationDirectory�"$PSScriptRoot\Generated"

Conversation

anponnet commented Feb 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

anponnet commented Feb 14, 2019

Uh oh!

anponnet commented Feb 14, 2019

Uh oh!

dsgouda commented Feb 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

anponnet commented Feb 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

anponnet commented Feb 14, 2019 •

edited

Loading

dsgouda commented Feb 14, 2019 •

edited

Loading