Support using MSI to fetch Key Vault access tokens#5249
Merged
shahabhijeet merged 1 commit intoAzure:masterfrom Feb 16, 2019
nickstenning:support-msi-for-keyvault-auth
Merged
Support using MSI to fetch Key Vault access tokens#5249shahabhijeet merged 1 commit intoAzure:masterfrom nickstenning:support-msi-for-keyvault-auth
shahabhijeet merged 1 commit intoAzure:masterfrom
nickstenning:support-msi-for-keyvault-auth
Conversation
In situations requiring cross-tenant auth, it is currently not possible to use MSI to fetch an access token directly. In these scenarios, it would be helpful to be able to use a client certificate grant, but with the certificate stored in Key Vault. Currently, this workflow is supported, but only for "development-like" environments (i.e. through the Visual Studio or Azure CLI token flows). This commit makes it possible for a service to use its managed identity to retrieve a Key Vault access token for client certificate grants.
Contributor
Author
|
Looks like @nonik0 may have thoughts on this change as the last (only?) person to change this file. |
Contributor
|
@schaabs do you know someone who could review this change? |
Contributor
|
@varunsh-msft will need to sign off on this PR |
Contributor
|
Thanks for bring this to our attention, @varunsh-msft and I will sync offline soon regarding this change. |
varunsh-coder
approved these changes
Feb 16, 2019
shahabhijeet
approved these changes
Feb 16, 2019
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
In situations requiring cross-tenant auth, it is currently not possible to use MSI to fetch an access token directly. In these scenarios, it would be helpful to be able to use a client certificate grant, but with the certificate stored in Key Vault. Currently, this workflow is supported, but only for "development-like" environments (i.e. through the Visual Studio or Azure CLI token flows). This commit makes it possible for a service to use its managed identity to retrieve a Key Vault access token for client certificate grants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In situations requiring cross-tenant auth, it is currently not possible to use MSI to fetch an access token directly. In these scenarios, it would be helpful to be able to use a client certificate grant, but with the certificate stored in (and retrieved from) Key Vault.
Currently, this workflow is supported, but only for "development-like" environments (i.e. through the Visual Studio or Azure CLI token flows). This commit makes it possible for a service to use its managed identity to retrieve a Key Vault access token for client certificate grants.
I'm very happy to take any and all feedback on this PR, for example I'm not sure if I need to update release notes/versions/etc. with this change. Please let me know!
This checklist is used to make sure that common guidelines for a pull request are followed.
Please add REST spec PR link to the SDK PR[Not applicable?]KeyVaultClientwill fall through to the remaining token providers in non-MSI environments.]General Guidelines
Testing Guidelines
KeyVaultClient. I'm happy to take advice on how this could be tested!]SDK Generation Guidelines
[Removed as not applicable.]