Merged
Conversation
dsgouda
suggested changes
Feb 14, 2019
src/SDKs/Kusto/Management.Kusto/Generated/SdkInfo_KustoManagementClient.cs
Show resolved
Hide resolved
shahabhijeet
approved these changes
Feb 22, 2019
weshaggard
reviewed
Feb 22, 2019
| @@ -23,20 +23,20 @@ namespace Microsoft.Azure.Management.Kusto | |||
| using System.Threading.Tasks; | |||
|
|
|||
| /// <summary> | |||
| /// EventHubConnectionsOperations operations. | |||
Member
There was a problem hiding this comment.
The renaming of this folder to "generated" from "Generated" for some of these files is causing issues when checking out these files. On windows it complains that there are changes and on I bet on unix it will have issues because these files will not be actually used. I think we should move these files back into the "Generated" folder.
weshaggard
added a commit
to weshaggard/azure-sdk-for-net
that referenced
this pull request
Feb 22, 2019
PR Azure#5248 accidently renamed some files to the generated folder instead of Generated which causes case-sensitivity issues.
shahabhijeet
pushed a commit
that referenced
this pull request
Feb 24, 2019
PR #5248 accidently renamed some files to the generated folder instead of Generated which causes case-sensitivity issues.
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
* Updated Kusto GA version * Fixed comments
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
PR Azure#5248 accidently renamed some files to the generated folder instead of Generated which causes case-sensitivity issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is Azure Data Explorer first GA SDK.
It includes new features, such as Database Principals and Data Connections
This checklist is used to make sure that common guidelines for a pull request are followed.
### This version includes breaking changes (Properties HotCachePeriod and SoftDeletePeriod for Database class), but It is our first GA version, so from my understanding, we are allowed to have breaking changes.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.Link to the swagger folder :
https://github.com/Azure/azure-rest-api-specs-pr/tree/master/specification/azure-kusto/resource-manager/Microsoft.Kusto/stable/2019-01-21