Regenerating preview SDK based off of latest swagger spec update#5203
Regenerating preview SDK based off of latest swagger spec update#5203brjohnstmsft merged 12 commits intoAzure:search-previewfrom arv100kri:skillset-configuration
Conversation
brjohnstmsft
left a comment
There was a problem hiding this comment.
We need to discuss potential backcompat concerns before I can merge this. Otherwise, the changes look good.
src/SDKs/Search/DataPlane/Microsoft.Azure.Search.Service/Generated/SearchServiceClient.cs
Show resolved
Hide resolved
.../Microsoft.Azure.Search.Tests.SearchManagementClientTests/RequestIdIsReturnedInResponse.json
Show resolved
Hide resolved
|
I missed it in my original review, but could you please also regenerate the code for |
|
yup, I've done that. Commit 797faef9823b453f4130d3ac4288f047bb84c8a5 In reply to: 459909441 [](ancestors = 459909441) |
brjohnstmsft
left a comment
There was a problem hiding this comment.
Had a question about a credential in a test; Otherwise LGTM.
src/SDKs/Search/DataPlane/Search.Tests/Tests/DataSourceTests.cs
Outdated
Show resolved
Hide resolved
brjohnstmsft
left a comment
There was a problem hiding this comment.
@arv100kri Changes look good. We just need to wait for your Swagger change to be merged so you can regenerate one more time to update the metadata, and then I'll merge this.
|
@arv100kri Apparently I'm a bit behind. I see the Swagger has been merged, and the metadata indicates that the regenerated code was based off Azure/master. I'm going to merge this now. |
Description
DefaultLanguageCodeparameter forOcrSkillDataSourceTeststo also account for stricter validationSearchManagementClientTestsThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.