Skip to content

Fix AzureDeveloperCliCredential hanging when AZD_DEBUG is set #52013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2025
Merged

Fix AzureDeveloperCliCredential hanging when AZD_DEBUG is set #52013

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65fa38b
Initial plan
Copilot Aug 15, 2025
9cbe893
Add --no-prompt flag to AzureDeveloperCliCredential commands
Copilot Aug 15, 2025
3fb2393
Add changelog entry for AzureDeveloperCliCredential fix
Copilot Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/identity/Azure.Identity/src/Credentials/AzureDeveloperCliCredential.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ private static void GetFileNameAndArguments(string[] scopes, string tenantId, ou
string scopeArgs = string.Join(" ", scopes.Select(scope => $"--scope {scope}"));
string command = tenantId switch
{
null => $"azd auth token --output json {scopeArgs}",
_ => $"azd auth token --output json {scopeArgs} --tenant-id {tenantId}"
null => $"azd auth token --output json --no-prompt {scopeArgs}",
_ => $"azd auth token --output json --no-prompt {scopeArgs} --tenant-id {tenantId}"
};

if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
Expand Down
16 changes: 16 additions & 0 deletions sdk/identity/Azure.Identity/tests/AzureDeveloperCliCredentialTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,22 @@ public async Task AuthenticateWithDeveloperCliCredential(
}
}

[Test]
public async Task AuthenticateWithDeveloperCliCredential_IncludesNoPromptFlag()
{
var context = new TokenRequestContext(new[] { Scope });
var (expectedToken, expectedExpiresOn, processOutput) = CredentialTestHelpers.CreateTokenForAzureDeveloperCli();

var testProcess = new TestProcess { Output = processOutput };
AzureDeveloperCliCredential credential =
InstrumentClient(new AzureDeveloperCliCredential(CredentialPipeline.GetInstance(null), new TestProcessService(testProcess, true)));
AccessToken actualToken = await credential.GetTokenAsync(context);

Assert.AreEqual(expectedToken, actualToken.Token);
Assert.AreEqual(expectedExpiresOn, actualToken.ExpiresOn);
Assert.That(testProcess.StartInfo.Arguments, Does.Contain("--no-prompt"));
}

[Test]
public void AuthenticateWithCliCredential_InvalidJsonOutput(
[Values("", "{}", "{\"Some\": false}", "{\"token\": \"token\"}", "{\"expiresOn\" : \"1900-01-01T00:00:00Z\"}")]
Expand Down