[Storage] [DataMovement] Fixed Preservation during Directory Overwrite #52002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickliu-msft
requested review from
amnguye,
jalauzon-msft,
jaschrep-msft and
seanmcc-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes property/permission/metadata preservation during directory overwrite operations for SMB and NFS storage resources. The main issue was that when overwriting existing directories, the source properties were not being properly applied to the destination.
- Fixed directory creation logic to support overwrite mode with property preservation
- Added comprehensive test coverage for directory overwrite scenarios with SMB and NFS protocols
- Added OAuth authentication tests for NFS operations
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TransferJobInternal.cs | Updated directory creation to use new overwrite-aware CreateAsync method |
| StorageResourceContainer.cs | Added new virtual CreateAsync method supporting overwrite with source properties |
| ShareDirectoryStorageResourceContainer.cs | Implemented overwrite logic with metadata/properties preservation |
| DataMovementSharesExtensions.cs | Renamed method for clarity (GetFilePermission → GetDirectoryPermission) |
| ShareFileStorageResource.cs | Added new error message for directory overwrite conflicts |
| ClientBuilderExtensions.cs | Added OAuth NFS test client builder method |
| ShareFileStartTransferCopyTests.cs | Added overwrite tests for file transfers and OAuth NFS tests |
| ShareDirectoryStartTransferCopyTests.cs | Added comprehensive directory overwrite tests for both SMB and NFS |
| assets.json files | Updated test asset tags |
...torage/Azure.Storage.DataMovement.Files.Shares/src/ShareDirectoryStorageResourceContainer.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement.Files.Shares/tests/ShareFileStartTransferCopyTests.cs
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
...torage/Azure.Storage.DataMovement.Files.Shares/src/ShareDirectoryStorageResourceContainer.cs
Outdated
Show resolved
Hide resolved
...torage/Azure.Storage.DataMovement.Files.Shares/src/ShareDirectoryStorageResourceContainer.cs
Show resolved
Hide resolved
...torage/Azure.Storage.DataMovement.Files.Shares/src/ShareDirectoryStorageResourceContainer.cs
Show resolved
Hide resolved
...torage/Azure.Storage.DataMovement.Files.Shares/src/ShareDirectoryStorageResourceContainer.cs
Outdated
Show resolved
Hide resolved
jalauzon-msft
approved these changes
Aug 19, 2025
...torage/Azure.Storage.DataMovement.Files.Shares/src/ShareDirectoryStorageResourceContainer.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed property/permission/metadata preservation when overwriting an existing directory. This applies to SMB and NFS. Also added some OAuth tests for NFS.