[GuestConfiguration]Add version field to ConfigurationInfo#5199
Merged
dsgouda merged 6 commits intoAzure:masterfrom Feb 1, 2019
aashish1987:AddVersionField
Merged
[GuestConfiguration]Add version field to ConfigurationInfo#5199dsgouda merged 6 commits intoAzure:masterfrom aashish1987:AddVersionField
dsgouda merged 6 commits intoAzure:masterfrom
aashish1987:AddVersionField
Conversation
Member
Author
dsgouda
suggested changes
Feb 1, 2019
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
@aashish1987 please regenerate the code using generate.ps1 and update the PR.
Also, please bump nuget version to 1.1.0 in the csproj and AssemblyInfo.cs and update the PackageReleaseNotes accordingly
dsgouda
suggested changes
Feb 1, 2019
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks good apart from a minor change
src/SDKs/GuestConfiguration/Management.GuestConfiguration/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
dsgouda
approved these changes
Feb 1, 2019
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM will merge once CIs pass
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
* Added Version field to ConfigurationInfo object * Updated SDK from swagger specs * Update test cases to include version field in ConfigurationInfo class * Update the version to 1.1.0 and generated sdk from latest swagger specs * Updated the test json files to reflect the new version * Reverting Assembly version back to 1.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.