[Automation] SavedSearch Dynamic group Sdk change and other nit fixes#5187
Closed
jemex wants to merge 1 commit intoAzure:psSdkJson6from
jemex:SavedSearchDynamicGroup
Closed
[Automation] SavedSearch Dynamic group Sdk change and other nit fixes#5187jemex wants to merge 1 commit intoAzure:psSdkJson6from jemex:SavedSearchDynamicGroup
jemex wants to merge 1 commit intoAzure:psSdkJson6from
jemex:SavedSearchDynamicGroup
Conversation
shahabhijeet
suggested changes
Jan 30, 2019
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
Get latest source from master and target against master branch.
Also go through the documentation and use the generate.ps1 to generate your SDK.
The generated SDK is lacking metadata that is important, follow step 7 from below documentation
https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#sdk-directory-structure-and-sdk-generation
Contributor
|
This PR cannot be accepted as is, take the appropriate action as described above and open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dynamic Group support change
API PR: Azure/azure-rest-api-specs#4964
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.