Sync eng/common directory with azure-sdk-tools for PR 11531#51732
Merged
Sync eng/common directory with azure-sdk-tools for PR 11531#51732
Conversation
azure-sdk
requested review from
benbp and
Copilot
and removed request for
benbp
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools, specifically updating user authentication logic to use HomeAccountId instead of performing lookups via Get-AzADUser calls.
- Replaces Get-AzADUser lookups with HomeAccountId parsing for better performance and reliability
- Simplifies user object ID retrieval by extracting from the HomeAccountId property
- Maintains the same functionality while reducing API calls
Comments suppressed due to low confidence (1)
eng/common/TestResources/New-TestResources.ps1:438
- The variable name '$testApplicationOid' should be '$TestApplicationOid' to maintain consistent casing with other variables in this context.
$TestApplicationId = $testApplicationOid
benbp
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11531 See eng/common workflow