[HDInsight] - Support ADLS Gen2 MSI#5173
Merged
dsgouda merged 1 commit intoAzure:masterfrom Jan 30, 2019
Merged
Conversation
idear1203
force-pushed
the
hdi_support_msi_for_adls_gen2
branch
from
697f0cc to
333b29d
Compare
dsgouda
suggested changes
Jan 24, 2019
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks good apart from versioning. Will reach out offline to discuss
| <Description>Azure HDInsight Management SDK Library</Description> | ||
| <AssemblyName>Microsoft.Azure.Management.HDInsight</AssemblyName> | ||
| <Version>4.2.0-preview</Version> | ||
| <Version>4.3.0-preview</Version> |
Contributor
There was a problem hiding this comment.
We need to take a look at the versioning story here, this is inconsistent with our versioning guidelines
Contributor
Author
There was a problem hiding this comment.
Thanks for helping review this. Change the version number to 4.2.1-preview.
dsgouda
suggested changes
Jan 25, 2019
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks good apart from a minor change
Contributor
There was a problem hiding this comment.
Since this is a breaking change, please revert this to 4.3.0-preview. We need to revisit the versioning when you wish to move to the next API version or when you release the next stable version
idear1203
force-pushed
the
hdi_support_msi_for_adls_gen2
branch
from
c1cd08e to
333b29d
Compare
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Swagger PR Links
Note
ResourceIdandMsiResourceIdproperty to classStorageAccountThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.