Skip to content

Generate new SDK for ManagedServiceIdentity with new swagger api version #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wendyNEU wants to merge 4 commits into from
Closed

Generate new SDK for ManagedServiceIdentity with new swagger api version #5165

wendyNEU wants to merge 4 commits into from

Conversation

@wendyNEU
Copy link
Contributor

@wendyNEU wendyNEU commented Jan 22, 2019

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Jan 22, 2019

@wendyNEU

  • Please fix the PR description/title
  • Looks like no new code was generated. Please create a generate.ps1 file similar to this and regenerate the code.

@wendyNEU wendyNEU changed the title Ps sdk json6 Generate new SDK for ManagedServiceIdentity with new swagger api version Jan 23, 2019
@wendyNEU
Copy link
Contributor Author

wendyNEU commented Jan 23, 2019

Hi dsgouda, generate.cmd already exist, do we still need generate.ps1?

@dsgouda
Copy link
Contributor

dsgouda commented Jan 23, 2019

@wendyNEU yes, we are moving all RPs to using generate.ps1 to generate SDKs

dsgouda
dsgouda suggested changes Jan 23, 2019
View reviewed changes
...dServiceIdentity/Management.ManagedServiceIdentity/Generated/ManagedServiceIdentityClient.cs
Operations = new Operations(this);
UserAssignedIdentities = new UserAssignedIdentitiesOperations(this);
BaseUri = new System.Uri("https://management.azure.com");
ApiVersion = "2015-08-31-preview";
Copy link
Contributor

@dsgouda dsgouda Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wendyNEU are you planning to release a stable version for your api version 2015-08-31-preview ?

Copy link
Contributor Author

@wendyNEU wendyNEU Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to release a stable version for api version 2018-11-30

...y/Management.ManagedServiceIdentity/Microsoft.Azure.Management.ManagedServiceIdentity.csproj
<Version>0.11.0</Version>
<AssemblyName>Microsoft.Azure.Management.ManagedServiceIdentity</AssemblyName>
<PackageTags>Microsoft Azure resource management;msi;managedserviceidentity;</PackageTags>
<PackageReleaseNotes>Taking dependency on 10.0.3 version of Newtonsoft nuget package.</PackageReleaseNotes>
Copy link
Contributor

@dsgouda dsgouda Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PackageReleaseNotes here

...y/Management.ManagedServiceIdentity/Microsoft.Azure.Management.ManagedServiceIdentity.csproj
<PackageId>Microsoft.Azure.Management.ManagedServiceIdentity</PackageId>
<Description>Provides developers with libraries for ManagedSericeIdentity under Azure Resource manager to perform CRUD operations on identities.</Description>
<Version>0.10.0-preview</Version>
<Description>Provides developers with libraries for ManagedServiceIdentity under Azure Resource manager to perform CRUD operations on identities.</Description>
Copy link
Contributor

@dsgouda dsgouda Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove description, use PackageReleaseNotes instead

README.md


# Microsoft Azure SDK for .NET
## All PRs should be opened against master branch. This branch is being retired and will be deleted.
Copy link
Contributor

@dsgouda dsgouda Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already defaulted our repo to master branch, don't think we need this change. Appreciate the help

@wendyNEU
Copy link
Contributor Author

wendyNEU commented Jan 23, 2019

It seems the test is broken, will take a look and send another commit to fix it.

@wendyNEU wendyNEU closed this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wendyNEU @dsgouda @shahabhijeet