Skip to content

Add Azure Function and remove Validation and Webhook activities #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsgouda merged 1 commit into from
Jan 19, 2019
Merged

Add Azure Function and remove Validation and Webhook activities #5158

dsgouda merged 1 commit into from
Jan 19, 2019

Conversation

@arsunda
Copy link
Contributor

@arsunda arsunda commented Jan 18, 2019 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@arsunda
Copy link
Contributor Author

arsunda commented Jan 18, 2019

Relevant REST PRs after last SDK release:
Azure/azure-rest-api-specs#5010

dsgouda
dsgouda suggested changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, please revert to the questions.

src/SDKs/DataFactory/Management.DataFactory/Generated/Models/ValidationActivity.cs
/// (or Expression with resultType string), pattern:
/// ((\d+)\.)?(\d\d):(60|([0-5][0-9])):(60|([0-5][0-9])).
/// </summary>
[JsonProperty(PropertyName = "typeProperties.timeout")]
Copy link
Contributor

@dsgouda dsgouda Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this is a breaking change

Copy link
Contributor

@hvermis hvermis Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda This changes hasn't been released yet. We had similar comments on Specs PR and got sign off from them and ARM team. These are new activities we added last week, but didn't want them in this release, so we took them out

src/SDKs/DataFactory/Management.DataFactory/Microsoft.Azure.Management.DataFactory.csproj
<PackageTags>Microsoft Azure resource management;Data Factory;ADF;</PackageTags>
<PackageReleaseNotes> <![CDATA[
- Added table name in dataset
- Added get Dataplane access API
Copy link
Contributor

@dsgouda dsgouda Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, are you planning to bump the version in a different PR

Copy link
Contributor

@hvermis hvermis Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is already bumped by Meiyan in her PR to 3.0.0. That has not been released yet.

dsgouda
dsgouda approved these changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 42f190a into Azure:psSdkJson6 Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvermis hvermis hvermis left review comments

+1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arsunda @dsgouda @hvermis