Sync eng/common directory with azure-sdk-tools for PR 11353#51483
Merged
Sync eng/common directory with azure-sdk-tools for PR 11353#51483
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools for PR 11353, updating PowerShell scripts with bug fixes and improvements. The changes focus on fixing path handling and ensuring proper directory creation.
- Fixed shell profile modification to include proper newline formatting
- Corrected shebang line for better shell compatibility
- Enhanced directory creation logic to prevent file copy failures
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Helpers/AzSdkTool-Helpers.ps1 | Added newline character before path command in shell profile |
| eng/common/mcp/azure-sdk-mcp.ps1 | Fixed shebang, added directory creation check, and improved variable naming |
benbp
approved these changes
Jul 25, 2025
azure-sdk
deleted the
sync-eng/common-benbp/copilot-install-mac-fixes-11353
branch
Copilot AI
pushed a commit
that referenced
this pull request
Jul 25, 2025
* Handle tool/directory copy better * Use /usr/bin/env instead of /bin/env * Append additional newline --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11353 See eng/common workflow