Skip to content

Devtest Labs .NET SDK update after typespec conversion#51337

Closed
nandiniYeltiwar wants to merge 9 commits intoAzure:mainfrom
nandiniYeltiwar:dev/nandiniy/TSP
Closed

Devtest Labs .NET SDK update after typespec conversion#51337
nandiniYeltiwar wants to merge 9 commits intoAzure:mainfrom
nandiniYeltiwar:dev/nandiniy/TSP

Conversation

@nandiniYeltiwar
Copy link

@nandiniYeltiwar nandiniYeltiwar commented Jul 17, 2025 •
edited
Loading

Updating the .NET SDK Code based on typespec conversion PR in REST API repo: Azure/azure-rest-api-specs#35346

Copilot AI review requested due to automatic review settings July 17, 2025 23:41
Copilot AI reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Jul 17, 2025
nandiniYeltiwar
nandiniYeltiwar commented Aug 1, 2025
View reviewed changes
sdk/devtestlabs/Azure.ResourceManager.DevTestLabs/src/Generated/Models/ArmTemplateList.cs
internal ArmTemplateList()
/// <param name="value"> The ArmTemplate items on this page. </param>
/// <exception cref="ArgumentNullException"> <paramref name="value"/> is null. </exception>
internal ArmTemplateList(IEnumerable<DevTestLabArmTemplateData> value)
Copy link
Author

@nandiniYeltiwar nandiniYeltiwar Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArcturusZhang All the list models have been updated to take IEnumerable<> as a parameter. Is that okay? Will it counted as breaking change?

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Hi @nandiniYeltiwar. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

Hi @nandiniYeltiwar. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Oct 10, 2025
@ArthurMa1978 ArthurMa1978 mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees

No one assigned

Labels

Mgmt This issue is related to a management package. no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nandiniYeltiwar @ArcturusZhang