[deviceprovisioningservices] Generate SDK from TypeSpec#51325
[deviceprovisioningservices] Generate SDK from TypeSpec#51325ArthurMa1978 merged 7 commits intoAzure:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR generates a new Azure Device Provisioning Services SDK from TypeSpec, targeting API version 2025-02-01-preview. The changes include the addition of new authentication types and properties for enhanced IoT Hub connectivity and service management.
Key changes include:
- Addition of new authentication type enums for IoT Hub connections (KeyBased, SystemAssigned, UserAssigned)
- New properties for managed service identity, resource group, and subscription ID tracking
- Enhanced IoT Hub definition with authentication type and user-assigned identity support
Reviewed Changes
Copilot reviewed 6 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Configuration file specifying TypeSpec source location and commit |
| src.sln | Visual Studio solution file for the project |
| IotHubDefinitionDescription.cs | Custom constructor for IoT Hub definition with connection string validation |
| Azure.ResourceManager.DeviceProvisioningServices.netstandard2.0.cs | API surface updates for .NET Standard 2.0 with new authentication features |
| Azure.ResourceManager.DeviceProvisioningServices.net8.0.cs | API surface updates for .NET 8.0 with new authentication features |
| CHANGELOG.md | Documentation of the new beta release |
Comments suppressed due to low confidence (5)
sdk/deviceprovisioningservices/Azure.ResourceManager.DeviceProvisioningServices/src/Custom/IotHubDefinitionDescription.cs:19
- [nitpick] The constructor parameter name 'connectionString' should be consistent with the property name 'ConnectionString' in terms of casing convention. Consider using 'connectionString' to follow camelCase parameter naming.
public IotHubDefinitionDescription(string connectionString, AzureLocation location):this(location)
sdk/deviceprovisioningservices/Azure.ResourceManager.DeviceProvisioningServices/api/Azure.ResourceManager.DeviceProvisioningServices.netstandard2.0.cs:56
- The property name 'Resourcegroup' should follow Pascal case naming convention. It should be 'ResourceGroup' instead of 'Resourcegroup'.
public string Resourcegroup { get { throw null; } set { } }
sdk/deviceprovisioningservices/Azure.ResourceManager.DeviceProvisioningServices/api/Azure.ResourceManager.DeviceProvisioningServices.netstandard2.0.cs:58
- The property name 'Subscriptionid' should follow Pascal case naming convention. It should be 'SubscriptionId' instead of 'Subscriptionid'.
public string Subscriptionid { get { throw null; } set { } }
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.