Skip to content

[deviceprovisioningservices] Generate SDK from TypeSpec#51325

Merged
ArthurMa1978 merged 7 commits intoAzure:mainfrom
welovej:deviceprovisioningservices-sdk-tsp
Jul 23, 2025
Merged

[deviceprovisioningservices] Generate SDK from TypeSpec#51325
ArthurMa1978 merged 7 commits intoAzure:mainfrom
welovej:deviceprovisioningservices-sdk-tsp

Conversation

@welovej
Copy link
Copy Markdown
Member

@welovej welovej commented Jul 17, 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copilot AI review requested due to automatic review settings July 17, 2025 08:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR generates a new Azure Device Provisioning Services SDK from TypeSpec, targeting API version 2025-02-01-preview. The changes include the addition of new authentication types and properties for enhanced IoT Hub connectivity and service management.

Key changes include:

  • Addition of new authentication type enums for IoT Hub connections (KeyBased, SystemAssigned, UserAssigned)
  • New properties for managed service identity, resource group, and subscription ID tracking
  • Enhanced IoT Hub definition with authentication type and user-assigned identity support

Reviewed Changes

Copilot reviewed 6 out of 51 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Configuration file specifying TypeSpec source location and commit
src.sln Visual Studio solution file for the project
IotHubDefinitionDescription.cs Custom constructor for IoT Hub definition with connection string validation
Azure.ResourceManager.DeviceProvisioningServices.netstandard2.0.cs API surface updates for .NET Standard 2.0 with new authentication features
Azure.ResourceManager.DeviceProvisioningServices.net8.0.cs API surface updates for .NET 8.0 with new authentication features
CHANGELOG.md Documentation of the new beta release
Comments suppressed due to low confidence (5)

sdk/deviceprovisioningservices/Azure.ResourceManager.DeviceProvisioningServices/src/Custom/IotHubDefinitionDescription.cs:19

  • [nitpick] The constructor parameter name 'connectionString' should be consistent with the property name 'ConnectionString' in terms of casing convention. Consider using 'connectionString' to follow camelCase parameter naming.
        public IotHubDefinitionDescription(string connectionString, AzureLocation location):this(location)

sdk/deviceprovisioningservices/Azure.ResourceManager.DeviceProvisioningServices/api/Azure.ResourceManager.DeviceProvisioningServices.netstandard2.0.cs:56

  • The property name 'Resourcegroup' should follow Pascal case naming convention. It should be 'ResourceGroup' instead of 'Resourcegroup'.
        public string Resourcegroup { get { throw null; } set { } }

sdk/deviceprovisioningservices/Azure.ResourceManager.DeviceProvisioningServices/api/Azure.ResourceManager.DeviceProvisioningServices.netstandard2.0.cs:58

  • The property name 'Subscriptionid' should follow Pascal case naming convention. It should be 'SubscriptionId' instead of 'Subscriptionid'.
        public string Subscriptionid { get { throw null; } set { } }

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Jul 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 17, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.DeviceProvisioningServices

@ArthurMa1978 ArthurMa1978 merged commit 9dd87a8 into Azure:main Jul 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants