Skip to content

Conversation

@jskulavik
Copy link
Contributor

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

There was an update to the REST API Specification PR that was a predecessor to this PR.

@jskulavik jskulavik closed this Jan 4, 2019
@jskulavik jskulavik deleted the aks-update branch January 4, 2019 05:53
@jskulavik jskulavik reopened this Jan 4, 2019
@dsgouda
Copy link
Contributor

dsgouda commented Jan 7, 2019

Please fix the failing test cases

@jskulavik jskulavik closed this Jan 8, 2019
@jskulavik jskulavik reopened this Jan 10, 2019
@jskulavik jskulavik closed this Jan 12, 2019
@jskulavik jskulavik reopened this Jan 15, 2019
@shahabhijeet shahabhijeet changed the base branch from psSdkJson6 to master January 21, 2019 00:09
@shahabhijeet shahabhijeet reopened this Jan 21, 2019
Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cleanup your commit history and then this PR will be reviewed/merged.
Have logical set of commits, currently this PR has way too many commits and needs to be cleaned up.

BrianBlum and others added 8 commits January 22, 2019 12:26
…ft.Azure.Management.Media.csproj (#5073)

* Updates for the 2018-07-01 version of the .Net SDK for Azure Media Services
    * The PresentationTimeRange properties are no longer 'required' for AssetFilters and AccountFilters.
    * The $top and $skip query options for Jobs and Transforms have been removed and $orderby was added. As part of adding the new ordering functionality, it was discovered that the $top and $skip options had accidentally been exposed previously even though they are not implemented.
    * Enumeration extensibility was re-enabled. This feature was enabled in the preview versions of the SDK and got accidentally disabled in the GA version.
    * Two predefined streaming policies have been renamed. SecureStreaming is now MultiDrmCencStreaming. SecureStreamingWithFairPlay is now Predefined_MultiDrmStreaming.

* Update the minor version in Microsoft.Azure.Management.Media.
Today the ignore scopes are only passed in via our build definitions
but that make it hard to keep updated as well as makes it difficult to
reproduce the same builds locally. To help with that we are committing
the list to a props file in the repo.
@jskulavik jskulavik closed this Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants