-
Notifications
You must be signed in to change notification settings - Fork 5.1k
AKS updates to latest REST ContainerService specification #5114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please fix the failing test cases |
dsgouda
suggested changes
Jan 7, 2019
...ainerService/ContainerService.Tests/Microsoft.Azure.Management.ContainerService.Tests.csproj
Outdated
Show resolved
Hide resolved
...ainerService/ContainerService.Tests/Microsoft.Azure.Management.ContainerService.Tests.csproj
Outdated
Show resolved
Hide resolved
...ainerService/ContainerService.Tests/Microsoft.Azure.Management.ContainerService.Tests.csproj
Show resolved
Hide resolved
...tainerService/Management.ContainerService/Microsoft.Azure.Management.ContainerService.csproj
Outdated
Show resolved
Hide resolved
...tainerService/Management.ContainerService/Microsoft.Azure.Management.ContainerService.csproj
Show resolved
Hide resolved
…vice principal issues required by AKS
shahabhijeet
suggested changes
Jan 21, 2019
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cleanup your commit history and then this PR will be reviewed/merged.
Have logical set of commits, currently this PR has way too many commits and needs to be cleaned up.
…ft.Azure.Management.Media.csproj (#5073) * Updates for the 2018-07-01 version of the .Net SDK for Azure Media Services * The PresentationTimeRange properties are no longer 'required' for AssetFilters and AccountFilters. * The $top and $skip query options for Jobs and Transforms have been removed and $orderby was added. As part of adding the new ordering functionality, it was discovered that the $top and $skip options had accidentally been exposed previously even though they are not implemented. * Enumeration extensibility was re-enabled. This feature was enabled in the preview versions of the SDK and got accidentally disabled in the GA version. * Two predefined streaming policies have been renamed. SecureStreaming is now MultiDrmCencStreaming. SecureStreamingWithFairPlay is now Predefined_MultiDrmStreaming. * Update the minor version in Microsoft.Azure.Management.Media.
Today the ignore scopes are only passed in via our build definitions but that make it hard to keep updated as well as makes it difficult to reproduce the same builds locally. To help with that we are committing the list to a props file in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.There was an update to the REST API Specification PR that was a predecessor to this PR.