Skip to content

Scenario tests for dropped databases on Managed Instance#5107

Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from
v-djnisi:RestorableDroppedDatabases
Jan 19, 2019
Merged

Scenario tests for dropped databases on Managed Instance#5107
dsgouda merged 1 commit intoAzure:psSdkJson6from
v-djnisi:RestorableDroppedDatabases

Conversation

@v-djnisi
Copy link
Contributor

@v-djnisi v-djnisi commented Dec 20, 2018

Description

This are scenario tests for dropped databases. I added test testing gets for dropped databases, as well as update and get for short term retention on dropped databases.

Rest-api-specs: https://github.com/Azure/azure-rest-api-specs/pull/4953


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Dec 20, 2018

@v-djnisi the rest spec PR is inaccessible, please fix the link

@v-djnisi
Copy link
Contributor Author

v-djnisi commented Dec 21, 2018

@v-djnisi v-djnisi force-pushed the RestorableDroppedDatabases branch 2 times, most recently from 97909d9 to a4936c3 Compare December 21, 2018 18:11
@v-djnisi
Copy link
Contributor Author

I ran the same command but from ps file, and it somehow worked. Everything should be okay now.

@v-djnisi v-djnisi force-pushed the RestorableDroppedDatabases branch from a4936c3 to 7895668 Compare December 21, 2018 18:23
@dsgouda
Copy link
Contributor

dsgouda commented Dec 21, 2018

Thanks @v-djnisi will approve and merge once the REST spec PR is merged

@v-djnisi v-djnisi force-pushed the RestorableDroppedDatabases branch from 7895668 to 14df5de Compare January 18, 2019 17:51
@v-djnisi
Copy link
Contributor Author

Rest-api-specs was merged, regenerated synced code and squshed.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 2def30e into Azure:psSdkJson6 Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments