EventGrid: Regenerate new SDK for 2019-01-01 Api Version#5097
EventGrid: Regenerate new SDK for 2019-01-01 Api Version#5097ahamad-MS wants to merge 13 commits intoAzure:psSdkJson6from
Conversation
…SDK client from 3.0.0-preview to 3.0.1-preview
|
|
||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("1.0.0.0")] | ||
| [assembly: AssemblyVersion("2.0.0.0")] |
There was a problem hiding this comment.
This change in this file should be reverted - since this is the dataplane test AssemblyInfo, I don't think we need an assembly version update for this one.
|
|
||
| [assembly: AssemblyVersion("3.0.0.0")] | ||
| [assembly: AssemblyFileVersion("3.0.0.0")] | ||
| [assembly: AssemblyVersion("4.0.0.0")] |
There was a problem hiding this comment.
The change in this file should be reverted as this is the dataplane assemblyinfo.
| <AssemblyName>Microsoft.Azure.Management.EventGrid</AssemblyName> | ||
| <PackageTags>Microsoft Azure EventGrid Management;Event Grid;Event Grid management;</PackageTags> | ||
| <PackageReleaseNotes>Taking dependency on 10.0.3 version of Newtonsoft nuget package.</PackageReleaseNotes> | ||
| <PackageReleaseNotes>Introducing 2019-01-01 as new GA API version.</PackageReleaseNotes> |
There was a problem hiding this comment.
Suggest replacing this with "This corresponds to the 2019-01-01 stable API version that supports General Availability of the following functionality related to event subscriptions: DeadLetter destination, Storage queue as destination, HybridConnection as destination, manual handshake validation, and support for retry policies. Features that are still in preview (such as Event Grid domains or advanced filters support) can still be accessed using the 3.0.1-preview version of the SDK."
|
Can you please take a look at this PR or suggest someone? thx |
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
Please rebase and clean up your commits. Keep logical commits in the history.
Also use generate.ps1 to generate your SDK. You are missing meta data that get's generated as part of the SDK generation process.
|
|
||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("1.0.0.0")] | ||
| [assembly: AssemblyVersion("2.0.0.0")] |
There was a problem hiding this comment.
@ahamad-MS this is not required, you are never going to release your test nuget package.
Please undo this change, adds unnecessary commit history to the file.
Unless you have a very specific reason to bump up test assembly version.
|
Restarting new PR with fewer commits |
3 participants
Description
Regenerate new SDK for API Version 2019-01-01 based off the following new Swagger Spec: Azure/azure-rest-api-specs#4899
This checklist is used to make sure that common guidelines for a pull request are followed.
Please add REST spec PR link to the SDK PR
Event Grid 2019-01-01 API Version: Swagger and related test examples azure-rest-api-specs#4899
I have read the contribution guidelines.
The pull request does not introduce breaking changes.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
Event Grid 2019-01-01 API Version: Swagger and related test examples azure-rest-api-specs#4899
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.