Skip to content

Fix batch changelog and test#5088

Merged
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
matthchr:feature/fix-batch-changelog
Dec 17, 2018
Merged

Fix batch changelog and test#5088
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
matthchr:feature/fix-batch-changelog

Conversation

@matthchr
Copy link
Member

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@bgklein
Copy link
Contributor

bgklein commented Dec 14, 2018

LGTM.

@matthchr matthchr force-pushed the feature/fix-batch-changelog branch from 399371d to 385000b Compare December 14, 2018 21:39
@shahabhijeet shahabhijeet merged commit 7744012 into Azure:psSdkJson6 Dec 17, 2018
@matthchr matthchr deleted the feature/fix-batch-changelog branch January 9, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants